content/public/browser/android/content_view_core.h - Issue 2103243002: Factor out ContentViewAndroidDelegate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/browser/android/content_view_core.h

Issue 2103243002: Factor out ContentViewAndroidDelegate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/public/browser/android/content_view_core.h

diff --git a/content/public/browser/android/content_view_core.h b/content/public/browser/android/content_view_core.h

index 44a2e3f81128f5b7944a4edb42d9964cb4c06ffb..d4edba1839f2b85d726110fcf4fb17564df71169 100644

--- a/content/public/browser/android/content_view_core.h

+++ b/content/public/browser/android/content_view_core.h

@@ -57,8 +57,7 @@ class CONTENT_EXPORT ContentViewCore {

int end_offset)>& callback) = 0;

virtual ui::WindowAndroid* GetWindowAndroid() const = 0;

- virtual const base::android::JavaRef<jobject>& GetViewAndroidDelegate()

- const = 0;

+ virtual ui::ViewAndroid* GetViewAndroid() = 0;

no sievers 2016/07/14 23:14:32 I think we don't need this, see other comment.

Jinsuk Kim 2016/07/15 05:46:26 Done.

virtual cc::Layer* GetLayer() const = 0;

protected: