Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(588)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelContent.java

Issue 2103243002: Factor out ContentViewAndroidDelegate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelContent.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelContent.java b/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelContent.java
index 55db785f021036a1f4cb2eccd50ed96d9df770f2..fa6761b938f07abe1d41ecc2fbdef76ed651f2aa 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelContent.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelContent.java
@@ -5,6 +5,7 @@
package org.chromium.chrome.browser.compositor.bottombar;
import android.text.TextUtils;
+import android.view.View;
import org.chromium.base.VisibleForTesting;
import org.chromium.base.annotations.CalledByNative;
@@ -22,6 +23,7 @@ import org.chromium.content.browser.ContentViewCore;
import org.chromium.content_public.browser.LoadUrlParams;
import org.chromium.content_public.browser.WebContents;
import org.chromium.content_public.browser.WebContentsObserver;
+import org.chromium.ui.base.ViewAndroidDelegate;
/**
* Content container for an OverlayPanel. This class is responsible for the management of the
@@ -229,7 +231,23 @@ public class OverlayPanelContent {
// Creates an initially hidden WebContents which gets shown when the panel is opened.
WebContents panelWebContents = WebContentsFactory.createWebContents(false, true);
- mContentViewCore.initialize(cv, cv, panelWebContents, mActivity.getWindowAndroid());
+
+ // Dummny ViewAndroidDelegate since the container view for overlay panel is
+ // never added to the view hierarchy.
+ ViewAndroidDelegate delegate = new ViewAndroidDelegate() {
+ @Override
+ public void addView(View anchorView) { }
+
+ @Override
+ public void setViewPosition(View anchorView, float x, float y,
+ float width, float height, float scale, int leftMargin, int topMargin) { }
+
+ @Override
+ public void removeView(View anchorView) { }
+
+ };
+ mContentViewCore.initialize(cv, delegate, cv, panelWebContents,
+ mActivity.getWindowAndroid());
// Transfers the ownership of the WebContents to the native OverlayPanelContent.
nativeSetWebContents(mNativeOverlayPanelContentPtr, panelWebContents, mWebContentsDelegate);

Powered by Google App Engine
This is Rietveld 408576698