Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1362)

Side by Side Diff: chrome/browser/ui/android/autofill/password_generation_popup_view_android.cc

Issue 2103243002: Factor out ContentViewAndroidDelegate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/android/autofill/password_generation_popup_view_andr oid.h" 5 #include "chrome/browser/ui/android/autofill/password_generation_popup_view_andr oid.h"
6 6
7 #include <jni.h> 7 #include <jni.h>
8 8
9 #include "base/android/jni_android.h" 9 #include "base/android/jni_android.h"
10 #include "base/android/jni_string.h" 10 #include "base/android/jni_string.h"
(...skipping 17 matching lines...) Expand all
28 void PasswordGenerationPopupViewAndroid::SavedPasswordsLinkClicked( 28 void PasswordGenerationPopupViewAndroid::SavedPasswordsLinkClicked(
29 JNIEnv* env, 29 JNIEnv* env,
30 const JavaParamRef<jobject>& obj) { 30 const JavaParamRef<jobject>& obj) {
31 if (controller_) 31 if (controller_)
32 controller_->OnSavedPasswordsLinkClicked(); 32 controller_->OnSavedPasswordsLinkClicked();
33 } 33 }
34 34
35 void PasswordGenerationPopupViewAndroid::Dismissed( 35 void PasswordGenerationPopupViewAndroid::Dismissed(
36 JNIEnv* env, 36 JNIEnv* env,
37 const JavaParamRef<jobject>& obj) { 37 const JavaParamRef<jobject>& obj) {
38 DismissedInternal();
39 }
40
41 void PasswordGenerationPopupViewAndroid::DismissedInternal() {
38 if (controller_) 42 if (controller_)
39 controller_->ViewDestroyed(); 43 controller_->ViewDestroyed();
40 44
41 delete this; 45 delete this;
42 } 46 }
43 47
44 void PasswordGenerationPopupViewAndroid::PasswordSelected( 48 void PasswordGenerationPopupViewAndroid::PasswordSelected(
45 JNIEnv* env, 49 JNIEnv* env,
46 const JavaParamRef<jobject>& object) { 50 const JavaParamRef<jobject>& object) {
47 if (controller_) 51 if (controller_)
48 controller_->PasswordAccepted(); 52 controller_->PasswordAccepted();
49 } 53 }
50 54
51 // static 55 // static
52 bool PasswordGenerationPopupViewAndroid::Register(JNIEnv* env) { 56 bool PasswordGenerationPopupViewAndroid::Register(JNIEnv* env) {
53 return RegisterNativesImpl(env); 57 return RegisterNativesImpl(env);
54 } 58 }
55 59
56 PasswordGenerationPopupViewAndroid::~PasswordGenerationPopupViewAndroid() {} 60 PasswordGenerationPopupViewAndroid::~PasswordGenerationPopupViewAndroid() {}
57 61
58 void PasswordGenerationPopupViewAndroid::Show() { 62 void PasswordGenerationPopupViewAndroid::Show() {
59 JNIEnv* env = base::android::AttachCurrentThread(); 63 JNIEnv* env = base::android::AttachCurrentThread();
60 ui::ViewAndroid* view_android = controller_->container_view(); 64 ui::ViewAndroid* view_android = controller_->container_view();
61 65
62 DCHECK(view_android); 66 DCHECK(view_android);
63 67
68 popup_ = view_android->AcquireAnchorView();
69 if (popup_.is_null())
70 return;
64 java_object_.Reset(Java_PasswordGenerationPopupBridge_create( 71 java_object_.Reset(Java_PasswordGenerationPopupBridge_create(
65 env, reinterpret_cast<intptr_t>(this), 72 env, popup_.view().obj(), controller_->element_bounds().width(),
66 view_android->GetWindowAndroid()->GetJavaObject().obj(), 73 reinterpret_cast<intptr_t>(this),
67 view_android->GetViewAndroidDelegate().obj())); 74 view_android->GetWindowAndroid()->GetJavaObject().obj()));
68 75
69 UpdateBoundsAndRedrawPopup(); 76 UpdateBoundsAndRedrawPopup();
70 } 77 }
71 78
72 void PasswordGenerationPopupViewAndroid::Hide() { 79 void PasswordGenerationPopupViewAndroid::Hide() {
73 controller_ = NULL; 80 controller_ = NULL;
74 JNIEnv* env = base::android::AttachCurrentThread(); 81 JNIEnv* env = base::android::AttachCurrentThread();
75 Java_PasswordGenerationPopupBridge_hide(env, java_object_.obj()); 82 if (!java_object_.is_null()) {
83 Java_PasswordGenerationPopupBridge_hide(env, java_object_.obj());
84 } else {
85 DismissedInternal();
86 }
76 } 87 }
77 88
78 gfx::Size PasswordGenerationPopupViewAndroid::GetPreferredSizeOfPasswordView() { 89 gfx::Size PasswordGenerationPopupViewAndroid::GetPreferredSizeOfPasswordView() {
79 static const int kUnusedSize = 0; 90 static const int kUnusedSize = 0;
80 return gfx::Size(kUnusedSize, kUnusedSize); 91 return gfx::Size(kUnusedSize, kUnusedSize);
81 } 92 }
82 93
83 void PasswordGenerationPopupViewAndroid::UpdateBoundsAndRedrawPopup() { 94 void PasswordGenerationPopupViewAndroid::UpdateBoundsAndRedrawPopup() {
95 if (java_object_.is_null())
96 return;
97
84 JNIEnv* env = base::android::AttachCurrentThread(); 98 JNIEnv* env = base::android::AttachCurrentThread();
85 Java_PasswordGenerationPopupBridge_setAnchorRect( 99 ui::ViewAndroid* view_android = controller_->container_view();
86 env,
87 java_object_.obj(),
88 controller_->element_bounds().x(),
89 controller_->element_bounds().y(),
90 controller_->element_bounds().width(),
91 controller_->element_bounds().height());
92 100
101 DCHECK(view_android);
102 view_android->SetAnchorRect(popup_.view(), controller_->element_bounds());
93 ScopedJavaLocalRef<jstring> password = 103 ScopedJavaLocalRef<jstring> password =
94 base::android::ConvertUTF16ToJavaString(env, controller_->password()); 104 base::android::ConvertUTF16ToJavaString(env, controller_->password());
95 ScopedJavaLocalRef<jstring> suggestion = 105 ScopedJavaLocalRef<jstring> suggestion =
96 base::android::ConvertUTF16ToJavaString( 106 base::android::ConvertUTF16ToJavaString(
97 env, controller_->SuggestedText()); 107 env, controller_->SuggestedText());
98 ScopedJavaLocalRef<jstring> help = 108 ScopedJavaLocalRef<jstring> help =
99 base::android::ConvertUTF16ToJavaString(env, controller_->HelpText()); 109 base::android::ConvertUTF16ToJavaString(env, controller_->HelpText());
100 110
101 Java_PasswordGenerationPopupBridge_show( 111 Java_PasswordGenerationPopupBridge_show(
102 env, 112 env,
(...skipping 15 matching lines...) Expand all
118 return false; 128 return false;
119 } 129 }
120 130
121 // static 131 // static
122 PasswordGenerationPopupView* PasswordGenerationPopupView::Create( 132 PasswordGenerationPopupView* PasswordGenerationPopupView::Create(
123 PasswordGenerationPopupController* controller) { 133 PasswordGenerationPopupController* controller) {
124 return new PasswordGenerationPopupViewAndroid(controller); 134 return new PasswordGenerationPopupViewAndroid(controller);
125 } 135 }
126 136
127 } // namespace autofill 137 } // namespace autofill
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698