Factor out ContentViewAndroidDelegate

chrome/browser/ui/android/autofill/password_generation_popup_view_android.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/android/autofill/password_generation_popup_view_android.h"
 
 #include <jni.h>
 
 #include "base/android/jni_android.h"
 #include "base/android/jni_string.h"
@@ skipping 43 matching lines @@
 }
 
 PasswordGenerationPopupViewAndroid::~PasswordGenerationPopupViewAndroid() {}
 
 void PasswordGenerationPopupViewAndroid::Show() {
   JNIEnv* env = base::android::AttachCurrentThread();
   ui::ViewAndroid* view_android = controller_->container_view();
 
   DCHECK(view_android);
 
+  popup_ = view_android->AcquireAnchorView();
+  if (popup_.is_null())
+    return;
   java_object_.Reset(Java_PasswordGenerationPopupBridge_create(
-      env, reinterpret_cast<intptr_t>(this),
-      view_android->GetWindowAndroid()->GetJavaObject().obj(),
-      view_android->GetViewAndroidDelegate().obj()));
+      env, popup_.view().obj(), controller_->element_bounds().width(),
+      reinterpret_cast<intptr_t>(this),
+      view_android->GetWindowAndroid()->GetJavaObject().obj()));
 
   UpdateBoundsAndRedrawPopup();
 }
 
 void PasswordGenerationPopupViewAndroid::Hide() {
   controller_ = NULL;
   JNIEnv* env = base::android::AttachCurrentThread();

[no sievers, 2016/07/19 22:29:30]

This needs to avoid the Java call now if |!java_object_| because of the
early-out you added above.

[Jinsuk Kim, 2016/07/20 00:55:18]

Done.

   Java_PasswordGenerationPopupBridge_hide(env, java_object_.obj());
 }
 
 gfx::Size PasswordGenerationPopupViewAndroid::GetPreferredSizeOfPasswordView() {
   static const int kUnusedSize = 0;
   return gfx::Size(kUnusedSize, kUnusedSize);
 }
 
 void PasswordGenerationPopupViewAndroid::UpdateBoundsAndRedrawPopup() {
   JNIEnv* env = base::android::AttachCurrentThread();
-  Java_PasswordGenerationPopupBridge_setAnchorRect(
-      env,
-      java_object_.obj(),
-      controller_->element_bounds().x(),
-      controller_->element_bounds().y(),
-      controller_->element_bounds().width(),
-      controller_->element_bounds().height());
+  ui::ViewAndroid* view_android = controller_->container_view();
 
+  DCHECK(view_android);
+  view_android->SetAnchorRect(popup_.view(), controller_->element_bounds());
   ScopedJavaLocalRef<jstring> password =
       base::android::ConvertUTF16ToJavaString(env, controller_->password());
   ScopedJavaLocalRef<jstring> suggestion =
       base::android::ConvertUTF16ToJavaString(
           env, controller_->SuggestedText());
   ScopedJavaLocalRef<jstring> help =
       base::android::ConvertUTF16ToJavaString(env, controller_->HelpText());
 

[no sievers, 2016/07/19 22:29:30]

same here

[Jinsuk Kim, 2016/07/20 00:55:18]

Done.

   Java_PasswordGenerationPopupBridge_show(
       env,
       java_object_.obj(),
       controller_->IsRTL(),
       controller_->display_password(),
       password.obj(),
       suggestion.obj(),
       help.obj(),
       controller_->HelpTextLinkRange().start(),
       controller_->HelpTextLinkRange().end());
 }
 
 void PasswordGenerationPopupViewAndroid::PasswordSelectionUpdated() {}
 
 bool PasswordGenerationPopupViewAndroid::IsPointInPasswordBounds(
         const gfx::Point& point) {
   NOTREACHED();
   return false;
 }
 
 // static
 PasswordGenerationPopupView* PasswordGenerationPopupView::Create(
     PasswordGenerationPopupController* controller) {
   return new PasswordGenerationPopupViewAndroid(controller);
 }
 
 }  // namespace autofill