Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(585)

Unified Diff: chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html

Issue 2103233002: Visual polishing of the MD Clear Browsing Data dialog. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removed the margin Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html
diff --git a/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html b/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html
index 4640ad68dedd3951e56a0c195d94190e91671962..026a5b0d68b04941f511ac4cd874ad8131ae18ed 100644
--- a/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html
+++ b/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html
@@ -22,16 +22,22 @@
visibility: hidden;
}
+ #dialog .button-container {
+ border-top: 1px solid rgba(0, 0, 0, 0.14);
+ margin-top: 0;
+ padding-top: 10px;
+ }
+
+ #dialog .footer {
+ background-color: #fff;
+ }
+
.row {
align-items: center;
display: flex;
min-height: 40px;
}
- .row .start {
- flex: 1;
- }
-
paper-spinner {
-webkit-margin-end: 16px;
margin-bottom: auto;
@@ -85,6 +91,17 @@
display: none;
};
}
+
+ #clearFrom {
+ display: inline;
+ }
+
+ /* Cap the height on smaller screens to avoid unfavorable clipping. */
+ @media screen and (max-height: 714px) {
+ .body {
+ max-height: 270px;
+ }
+ }
</style>
<!-- #notice correctly places its own backdrop above #dialog and under
@@ -93,11 +110,13 @@
<div class="title">$i18n{clearBrowsingData}</div>
<div class="body">
<div class="row">
- <span class="start">$i18n{clearFollowingItemsFrom}</span>
- <settings-dropdown-menu id="clearFrom"
- pref="{{prefs.browser.clear_data.time_period}}"
- menu-options="[[clearFromOptions_]]" no-label-float>
- </settings-dropdown-menu>
+ <span>
+ $i18n{clearFollowingItemsFrom}
+ <settings-dropdown-menu id="clearFrom"
+ pref="{{prefs.browser.clear_data.time_period}}"
+ menu-options="[[clearFromOptions_]]" no-label-float>
+ </settings-dropdown-menu>
+ </span>
</div>
<settings-checkbox id="browsingCheckbox"
pref="{{prefs.browser.clear_data.browsing_history}}"
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698