Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Unified Diff: third_party/tlslite/tlslite/integration/pop3_tls.py

Issue 210323002: Update tlslite to 0.4.6. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Executable bit and --similarity=80 Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/tlslite/tlslite/integration/pop3_tls.py
diff --git a/third_party/tlslite/tlslite/integration/pop3_tls.py b/third_party/tlslite/tlslite/integration/pop3_tls.py
index 4faeee810e33c0aaf2616aa84a2eceb9f7037623..64f6124e12513568843abe07f0d86d8a1bb44aff 100644
--- a/third_party/tlslite/tlslite/integration/pop3_tls.py
+++ b/third_party/tlslite/tlslite/integration/pop3_tls.py
@@ -1,42 +1,37 @@
+# Author: Trevor Perrin
+# See the LICENSE file for legal information regarding use of this file.
+
"""TLS Lite + poplib."""
import socket
-from poplib import POP3
+from poplib import POP3, POP3_SSL_PORT
from tlslite.tlsconnection import TLSConnection
from tlslite.integration.clienthelper import ClientHelper
-# POP TLS PORT
-POP3_TLS_PORT = 995
-
class POP3_TLS(POP3, ClientHelper):
"""This class extends L{poplib.POP3} with TLS support."""
- def __init__(self, host, port = POP3_TLS_PORT,
- username=None, password=None, sharedKey=None,
+ def __init__(self, host, port = POP3_SSL_PORT,
+ timeout=socket._GLOBAL_DEFAULT_TIMEOUT,
+ username=None, password=None,
certChain=None, privateKey=None,
- cryptoID=None, protocol=None,
- x509Fingerprint=None,
- x509TrustList=None, x509CommonName=None,
+ checker=None,
settings=None):
"""Create a new POP3_TLS.
For client authentication, use one of these argument
combinations:
- username, password (SRP)
- - username, sharedKey (shared-key)
- certChain, privateKey (certificate)
For server authentication, you can either rely on the
implicit mutual authentication performed by SRP or
- shared-keys, or you can do certificate-based server
+ you can do certificate-based server
authentication with one of these argument combinations:
- - cryptoID[, protocol] (requires cryptoIDlib)
- x509Fingerprint
- - x509TrustList[, x509CommonName] (requires cryptlib_py)
Certificate-based server authentication is compatible with
- SRP or certificate-based client authentication. It is
- not compatible with shared-keys.
+ SRP or certificate-based client authentication.
The caller should be prepared to handle TLS-specific
exceptions. See the client handshake functions in
@@ -50,93 +45,40 @@ class POP3_TLS(POP3, ClientHelper):
@param port: Port to connect to.
@type username: str
- @param username: SRP or shared-key username. Requires the
- 'password' or 'sharedKey' argument.
-
+ @param username: SRP username.
+
@type password: str
@param password: SRP password for mutual authentication.
Requires the 'username' argument.
- @type sharedKey: str
- @param sharedKey: Shared key for mutual authentication.
- Requires the 'username' argument.
-
- @type certChain: L{tlslite.X509CertChain.X509CertChain} or
- L{cryptoIDlib.CertChain.CertChain}
+ @type certChain: L{tlslite.x509certchain.X509CertChain}
@param certChain: Certificate chain for client authentication.
- Requires the 'privateKey' argument. Excludes the SRP or
- shared-key related arguments.
+ Requires the 'privateKey' argument. Excludes the SRP argument.
- @type privateKey: L{tlslite.utils.RSAKey.RSAKey}
+ @type privateKey: L{tlslite.utils.rsakey.RSAKey}
@param privateKey: Private key for client authentication.
- Requires the 'certChain' argument. Excludes the SRP or
- shared-key related arguments.
-
- @type cryptoID: str
- @param cryptoID: cryptoID for server authentication. Mutually
- exclusive with the 'x509...' arguments.
-
- @type protocol: str
- @param protocol: cryptoID protocol URI for server
- authentication. Requires the 'cryptoID' argument.
+ Requires the 'certChain' argument. Excludes the SRP argument.
- @type x509Fingerprint: str
- @param x509Fingerprint: Hex-encoded X.509 fingerprint for
- server authentication. Mutually exclusive with the 'cryptoID'
- and 'x509TrustList' arguments.
+ @type checker: L{tlslite.checker.Checker}
+ @param checker: Callable object called after handshaking to
+ evaluate the connection and raise an Exception if necessary.
- @type x509TrustList: list of L{tlslite.X509.X509}
- @param x509TrustList: A list of trusted root certificates. The
- other party must present a certificate chain which extends to
- one of these root certificates. The cryptlib_py module must be
- installed to use this parameter. Mutually exclusive with the
- 'cryptoID' and 'x509Fingerprint' arguments.
-
- @type x509CommonName: str
- @param x509CommonName: The end-entity certificate's 'CN' field
- must match this value. For a web server, this is typically a
- server name such as 'www.amazon.com'. Mutually exclusive with
- the 'cryptoID' and 'x509Fingerprint' arguments. Requires the
- 'x509TrustList' argument.
-
- @type settings: L{tlslite.HandshakeSettings.HandshakeSettings}
+ @type settings: L{tlslite.handshakesettings.HandshakeSettings}
@param settings: Various settings which can be used to control
the ciphersuites, certificate types, and SSL/TLS versions
offered by the client.
"""
-
self.host = host
self.port = port
- msg = "getaddrinfo returns an empty list"
- self.sock = None
- for res in socket.getaddrinfo(self.host, self.port, 0, socket.SOCK_STREAM):
- af, socktype, proto, canonname, sa = res
- try:
- self.sock = socket.socket(af, socktype, proto)
- self.sock.connect(sa)
- except socket.error, msg:
- if self.sock:
- self.sock.close()
- self.sock = None
- continue
- break
- if not self.sock:
- raise socket.error, msg
-
- ### New code below (all else copied from poplib)
+ sock = socket.create_connection((host, port), timeout)
ClientHelper.__init__(self,
- username, password, sharedKey,
+ username, password,
certChain, privateKey,
- cryptoID, protocol,
- x509Fingerprint,
- x509TrustList, x509CommonName,
+ checker,
settings)
-
- self.sock = TLSConnection(self.sock)
- self.sock.closeSocket = True
- ClientHelper._handshake(self, self.sock)
- ###
-
+ connection = TLSConnection(sock)
+ ClientHelper._handshake(self, connection)
+ self.sock = connection
self.file = self.sock.makefile('rb')
self._debugging = 0
- self.welcome = self._getresp()
+ self.welcome = self._getresp()
« no previous file with comments | « third_party/tlslite/tlslite/integration/integrationhelper.py ('k') | third_party/tlslite/tlslite/integration/smtp_tls.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698