Adding version info to the client config request

chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_io_data.cc

Index: chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_io_data.cc
diff --git a/chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_io_data.cc b/chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_io_data.cc
index b61f77a62d76848cc36467bff5c205bfceb504e3..07ddb405faba62be2f53a46fd89b6be599db3c6e 100644
--- a/chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_io_data.cc
+++ b/chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_io_data.cc
@@ -3,27 +3,29 @@
 // found in the LICENSE file.
 
 #include "chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_io_data.h"
 
 #include <utility>
 
 #include "base/bind.h"
 #include "base/memory/ptr_util.h"
 #include "build/build_config.h"
 #include "chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.h"
+#include "chrome/common/channel_info.h"
 #include "chrome/common/chrome_content_client.h"
 #include "chrome/common/pref_names.h"
 #include "components/data_reduction_proxy/content/browser/content_lofi_decider.h"
 #include "components/data_reduction_proxy/content/browser/content_lofi_ui_service.h"
 #include "components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data.h"
 #include "components/data_reduction_proxy/core/common/data_reduction_proxy_params.h"
 #include "components/prefs/pref_service.h"
+#include "components/version_info/version_info.h"

[tbansal1, 2016/06/28 21:32:15]

why is this include needed?

[RyanSturm, 2016/06/28 22:22:13]

Done.

 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/web_contents.h"
 
 #if defined(OS_ANDROID)
 #include "base/android/build_info.h"
 #include "chrome/browser/android/tab_android.h"
 #endif
 
 namespace content {
 class BrowserContext;
@@ -72,19 +74,20 @@ CreateDataReductionProxyChromeIOData(
 #endif
 
   bool enabled =
       prefs->GetBoolean(prefs::kDataSaverEnabled) ||
       data_reduction_proxy::params::ShouldForceEnableDataReductionProxy();
   std::unique_ptr<data_reduction_proxy::DataReductionProxyIOData>
       data_reduction_proxy_io_data(
           new data_reduction_proxy::DataReductionProxyIOData(
               DataReductionProxyChromeSettings::GetClient(), flags, net_log,
               io_task_runner, ui_task_runner, enabled, GetUserAgent()));
+  data_reduction_proxy_io_data->set_channel(chrome::GetChannel());

[tbansal1, 2016/06/28 21:32:15]

Why not pass in the constructor? I think you can also change it to a string
because chrome::GetChannel() enum  is Chrome specific. Other embedders (e.g.,
Cronet) may use different enums, or may not use enums at all. String will
provide the flexibility to match up with all the embedders.

[RyanSturm, 2016/06/28 22:22:13]

Done.

 
   data_reduction_proxy_io_data->set_lofi_decider(
       base::WrapUnique(new data_reduction_proxy::ContentLoFiDecider()));
   data_reduction_proxy_io_data->set_lofi_ui_service(
       base::WrapUnique(new data_reduction_proxy::ContentLoFiUIService(
           ui_task_runner, base::Bind(&OnLoFiResponseReceivedOnUI))));
 
   return data_reduction_proxy_io_data;
 }