Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(764)

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client.cc

Issue 2103223002: Adding version info to the client config request (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nits Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client.cc
diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client.cc
index e652b5ce47f83840bdfc2e7ba8f688783b0e72b8..6fac40b29e8f92352ca8b1924e87b4a717bde205 100644
--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client.cc
+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client.cc
@@ -363,20 +363,29 @@ void DataReductionProxyConfigServiceClient::OnURLFetchComplete(
HandleResponse(response, status, source->GetResponseCode());
}
void DataReductionProxyConfigServiceClient::RetrieveRemoteConfig() {
DCHECK(thread_checker_.CalledOnValidThread());
CreateClientConfigRequest request;
std::string serialized_request;
const std::string& session_key = request_options_->GetSecureSession();
if (!session_key.empty())
request.set_session_key(request_options_->GetSecureSession());
+ data_reduction_proxy::VersionInfo* version_info =
+ request.mutable_version_info();
+ uint32_t build;
+ uint32_t patch;
+ util::GetChromiumBuildAndPatchAsInts(util::ChromiumVersion(), &build, &patch);
+ version_info->set_client(util::GetStringForClient(io_data_->client()));
+ version_info->set_build(build);
+ version_info->set_patch(patch);
+ version_info->set_channel(io_data_->channel());
request.SerializeToString(&serialized_request);
std::unique_ptr<net::URLFetcher> fetcher =
GetURLFetcherForConfig(config_service_url_, serialized_request);
if (!fetcher.get()) {
HandleResponse(std::string(),
net::URLRequestStatus::FromError(net::ERR_ABORTED),
net::URLFetcher::RESPONSE_CODE_INVALID);
return;
}

Powered by Google App Engine
This is Rietveld 408576698