Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(470)

Unified Diff: components/data_reduction_proxy/proto/client_config.proto

Issue 2103223002: Adding version info to the client config request (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Adding comment about allowed strings for client platform. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/data_reduction_proxy/core/common/data_reduction_proxy_util.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/data_reduction_proxy/proto/client_config.proto
diff --git a/components/data_reduction_proxy/proto/client_config.proto b/components/data_reduction_proxy/proto/client_config.proto
index 98cc093e0d4b565d1ce9fd9d9a305ab70c243761..9ee9064ac84dfe5001f72ecc5182c8d7181cefe6 100644
--- a/components/data_reduction_proxy/proto/client_config.proto
+++ b/components/data_reduction_proxy/proto/client_config.proto
@@ -102,11 +102,31 @@ message ProxyServer {
// The host name for the proxy server.
optional string host = 2;
// The port number for the proxy server.
optional int32 port = 3;
}
// Request object to create a client configuration object.
message CreateClientConfigRequest {
// A previous per-session key that was assigned by the service.
optional string session_key = 1;
+
+ // Build version information.
+ optional VersionInfo version_info = 2;
}
+
+// Build version information.
+message VersionInfo {
+ // The client's platform type. See
+ // components/data_reduction_proxy/core/common/data_reduction_proxy_util.h for
+ // allowed strings in CLIENT_ENUMS_LIST.
+ optional string client = 1;
+
+ // The version number, e.g. "6.0.490.1".
tbansal1 2016/06/29 17:58:26 I do not understand this comment. From the example
RyanSturm 2016/06/29 19:02:35 Done.
+ optional int32 build = 2;
+
+ // The patch number of the chromium client: always a non-negative integer.
+ optional int32 patch = 3;
+
+ // The production channel.
buettner 2016/06/29 18:04:44 Maybe it's clear enough to Chromium developers, bu
RyanSturm 2016/06/29 19:02:35 Done.
+ optional string channel = 4;
+}
« no previous file with comments | « components/data_reduction_proxy/core/common/data_reduction_proxy_util.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698