Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issue 2103213002: Follow system LTR/RTL direction in billing address spinner. (Closed)

Created:
4 years, 5 months ago by please use gerrit instead
Modified:
4 years, 5 months ago
Reviewers:
gone
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Follow system LTR/RTL direction in billing address spinner. BUG=623934 Committed: https://crrev.com/27fa86c52c413936f113d52fa144643eea5bf716 Cr-Commit-Position: refs/heads/master@{#402571}

Patch Set 1 #

Patch Set 2 : app compat #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M chrome/android/java/res/layout/autofill_credit_card_editor.xml View 1 3 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
please use gerrit instead
dfalcantara@, ptal. Screenshots in http://crbug.com/623934#c3
4 years, 5 months ago (2016-06-28 17:48:15 UTC) #2
please use gerrit instead
dfalcantara@, ptal patch 2. Using app compat spinner. Still need textDirection=locale though.
4 years, 5 months ago (2016-06-28 19:02:02 UTC) #3
gone
lgtm
4 years, 5 months ago (2016-06-28 19:06:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2103213002/20001
4 years, 5 months ago (2016-06-28 19:07:27 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-06-28 22:20:22 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-06-28 22:22:12 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/27fa86c52c413936f113d52fa144643eea5bf716
Cr-Commit-Position: refs/heads/master@{#402571}

Powered by Google App Engine
This is Rietveld 408576698