Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 21032: Tracking HWND creation/deletion (Closed)

Created:
11 years, 10 months ago by jcampan
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

This CL adds macro used to track the creation and destruction of HWNDs, in an attempt to detect potential double-delete. A double-delete of a HWND might be responsible for the crasher http://crbug.com/4714 Note: this CL was previously committed and reverted because it broke the sandbox integration module. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=9161

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+132 lines, -13 lines) Patch
M base/stats_table.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M base/time.cc View 2 chunks +2 lines, -1 line 0 comments Download
M base/win_util.h View 2 chunks +18 lines, -0 lines 0 comments Download
M base/win_util.cc View 2 chunks +63 lines, -0 lines 0 comments Download
M chrome/browser/plugin_process_host.cc View 3 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view_win.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/views/native_control.cc View 4 chunks +15 lines, -9 lines 0 comments Download
M chrome/views/text_field.cc View 4 chunks +13 lines, -0 lines 0 comments Download
M chrome/views/widget_win.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M webkit/glue/plugins/webplugin_delegate_impl.cc View 5 chunks +5 lines, -0 lines 0 comments Download
M webkit/tools/test_shell/webwidget_host_win.cc View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
jcampan
Sky, this is the same CL that you reviewed earlier on. It was breaking a ...
11 years, 10 months ago (2009-02-04 02:40:36 UTC) #1
jar (doing other things)
The changes to the stats_table.cc LGTM. I didn't review the rest.
11 years, 10 months ago (2009-02-04 05:32:26 UTC) #2
sky
11 years, 10 months ago (2009-02-04 15:56:27 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698