🎏 Fix google_play_services_default_java including legacy_http_javalib as a dep rather tha

build/secondary/third_party/android_tools/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/android/rules.gni")
 
 config("cpu_features_include") {
   include_dirs = [ "ndk/sources/android/cpufeatures" ]
 }
 
@@ skipping 109 matching lines @@
 android_resources("google_play_services_default_resources") {
   v14_skip = true
   resource_dirs = [ "$android_sdk_root/extras/google/google_play_services/libproject/google-play-services_lib/res" ]
   custom_package = "com.google.android.gms"
 }
 android_java_prebuilt("google_play_services_default_java") {
   deps = [
     ":android_support_v13_java",
     ":android_support_v7_mediarouter_java",
     ":google_play_services_default_resources",
-    ":legacy_http_javalib",

[paulmiller, 2016/06/28 18:10:21]

If not here, then where is "legacy_http_javalib" being used? Should we remove
it?

[agrieve, 2016/06/28 18:35:05]

It's still used by some test targets. Possible that those could also be changed
to use input_jars_paths, but we probably don't care enough just for test
targets. Also possible that robolectric tests might need it.

   ]
+  input_jars_paths = [ "$android_sdk/optional/org.apache.http.legacy.jar" ]
   proguard_preprocess = true
   proguard_config = "//third_party/android_tools/proguard.flags"
   jar_path = "$android_sdk_root/extras/google/google_play_services/libproject/google-play-services_lib/libs/google-play-services.jar"
 }
 
 android_resources("android_support_v17_leanback_resources") {
   v14_skip = true
   resource_dirs =
       [ "$android_sdk_root/extras/android/support/v17/leanback/res" ]
   custom_package = "android.support.v17.leanback"
 }
 
 android_java_prebuilt("android_support_v17_leanback_java") {
   deps = [
     ":android_support_v17_leanback_resources",
     ":android_support_v7_recyclerview_java",
   ]
   jar_path = "$android_sdk_root/extras/android/support/v17/leanback/libs/android-support-v17-leanback.jar"
 }
 
 # TODO(jbudorick): Remove this once net_java_test_support no longer needs it.
 android_java_prebuilt("legacy_http_javalib") {
+  testonly = true

[paulmiller, 2016/06/28 18:10:21]

What does "testonly" do?

[agrieve, 2016/06/28 18:35:05]

It will make gn gen fail if any target not marked as testonly depends on it. 

   jar_path = "$android_sdk/optional/org.apache.http.legacy.jar"
 }