tools/metrics/histograms/histograms.xml - Issue 2103153004: Add a histogram for delay between first paint and client side redirects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 2103153004: Add a histogram for delay between first paint and client side redirects. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add comment Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

« components/page_load_metrics/browser/metrics_web_contents_observer.cc ('K') | « components/page_load_metrics/browser/metrics_web_contents_observer.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index ca7c1d4e347237bcc444a7a68ce026769d82deb5..623a6805ba428774ec3ec1801aaaee2aa8fe9b67 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -37050,6 +37050,18 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

</summary>

</histogram>

+<histogram name="PageLoad.Internal.ClientRedirectDelayAfterPaint"

+ units="length">

Ilya Sherman 2016/06/29 20:16:12 Mmm, what does units="length" mean? Should the un

Bryan McQuade 2016/06/29 20:23:28 Good catch, thanks! Updated to ms.

+ <owner>bmcquade@chromium.org</owner>

+ <summary>

+ The delay between first paint and a client-side redirection. This metric is

+ only intended to help in choosing a heuristic delay to distinguish between

+ client-side redirects and other client initiated navigations, and will be

+ deprecated in M44. Please contact bmcquade@chromium.org before using this

Ilya Sherman 2016/06/29 20:16:12 nit: s/44/54

Charlie Harrison 2016/06/29 20:18:37 s/M44/M54?

Bryan McQuade 2016/06/29 20:23:28 Fixed

+ metric.

+ </summary>

+</histogram>

<histogram name="PageLoad.Internal.ProvisionalAbortChainSize.ForwardBack"

units="length">

<owner>csharrison@chromium.org</owner>