Add a histogram for delay between first paint and client side redirects.

Add a histogram for delay between first paint and client side redirects.

This will help us to choose a good heuristic value for distinguishing
client-side redirects from other client-side navigations.

BUG=613634
Committed: https://crrev.com/37f1e97746ee9257aac5c353b6b264f61b5ed172
Cr-Commit-Position: refs/heads/master@{#403026}

[Bryan McQuade, 2016-06-29 20:09:18]

bmcquade@chromium.org changed reviewers:
+ csharrison@chromium.org, isherman@chromium.org

[Bryan McQuade, 2016-06-29 20:09:48]

csharrison: PTAL for page_load_metrics
isherman: PTAL for histograms.xml

[Ilya Sherman, 2016-06-29 20:16:12]

LGTM % nits.  Thanks for clearly documenting the expected lifetime for this
histogram!

https://codereview.chromium.org/2103153004/diff/20001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2103153004/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:37054: +    units="length">
Mmm, what does units="length" mean?  Should the units be some sort of time
measurement?

https://codereview.chromium.org/2103153004/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:37060: +    deprecated in M44. Please
contact bmcquade@chromium.org before using this
nit: s/44/54

[Charlie Harrison, 2016-06-29 20:18:38]

lgtm % histogram comment. Thanks for looking into this.

https://codereview.chromium.org/2103153004/diff/20001/components/page_load_me...
File components/page_load_metrics/browser/metrics_web_contents_observer.cc
(right):

https://codereview.chromium.org/2103153004/diff/20001/components/page_load_me...
components/page_load_metrics/browser/metrics_web_contents_observer.cc:399:
PAGE_LOAD_HISTOGRAM(internal::kClientRedirectDelayAfterPaint,
I don't think it's necessary but let's keep in mind cases where
destination.navigation_start() < first_paint_time will get bucketed to zero
here. It may be worthwhile to have a histogram separating those out (as opposed
to combined with cases where the page did not paint at all).

https://codereview.chromium.org/2103153004/diff/20001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2103153004/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:37060: +    deprecated in M44. Please
contact bmcquade@chromium.org before using this
s/M44/M54?

[Bryan McQuade, 2016-06-29 20:23:28]

Thanks!

https://codereview.chromium.org/2103153004/diff/20001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2103153004/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:37054: +    units="length">
On 2016/06/29 at 20:16:12, Ilya Sherman wrote:
> Mmm, what does units="length" mean?  Should the units be some sort of time
measurement?

Good catch, thanks! Updated to ms.

https://codereview.chromium.org/2103153004/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:37060: +    deprecated in M44. Please
contact bmcquade@chromium.org before using this
On 2016/06/29 at 20:16:12, Ilya Sherman wrote:
> nit: s/44/54

Fixed

[Bryan McQuade, 2016-06-29 21:40:35]

The CQ bit was checked by bmcquade@chromium.org

[Bryan McQuade, 2016-06-29 21:40:36]

The patchset sent to the CQ was uploaded after l-g-t-m from
isherman@chromium.org, csharrison@chromium.org
Link to the patchset: https://codereview.chromium.org/2103153004/#ps40001
(title: "histogram xml fix")

[commit-bot: I haz the power, 2016-06-29 21:49:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 00:27:59]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-30 00:28:09]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-06-30 00:29:43]

Description was changed from

==========
Add a histogram for delay between first paint and client side redirects.

This will help us to choose a good heuristic value for distinguishing
client-side redirects from other client-side navigations.

BUG=613634
==========

to

==========
Add a histogram for delay between first paint and client side redirects.

This will help us to choose a good heuristic value for distinguishing
client-side redirects from other client-side navigations.

BUG=613634

Committed: https://crrev.com/37f1e97746ee9257aac5c353b6b264f61b5ed172
Cr-Commit-Position: refs/heads/master@{#403026}
==========

[commit-bot: I haz the power, 2016-06-30 00:29:44]

Patchset 3 (id:??) landed as
https://crrev.com/37f1e97746ee9257aac5c353b6b264f61b5ed172
Cr-Commit-Position: refs/heads/master@{#403026}