Restrict PPAPI Win32k lockdown to Win10 and above.

Restrict PPAPI Win32k lockdown to Win10 and above.
This patch restricts enabling Win32k lockdown for PPAPI processes to
Windows 10 and above. It includes a change to the flag text to indicate
it only works on Windows 10.

BUG=523278
Committed: https://crrev.com/a6fc996adfc9a973536804fb1dcd28c24da84a80
Cr-Commit-Position: refs/heads/master@{#402872}

[forshaw, 2016-06-29 15:28:35]

forshaw@chromium.org changed reviewers:
+ jam@chromium.org

[forshaw, 2016-06-29 15:28:35]

jam@ could you take at these minor changes I would like to get in before the M53
branch?

Thanks.

[jam, 2016-06-29 17:12:00]

On 2016/06/29 15:28:35, forshaw wrote:
> jam@ could you take at these minor changes I would like to get in before the
M53
> branch?
> 
> Thanks.

lgtm

[forshaw, 2016-06-29 17:28:03]

On 2016/06/29 17:12:00, jam wrote:
> On 2016/06/29 15:28:35, forshaw wrote:
> > jam@ could you take at these minor changes I would like to get in before the
> M53
> > branch?
> > 
> > Thanks.
> 
> lgtm

Thanks very much.

[forshaw, 2016-06-29 17:28:11]

The CQ bit was checked by forshaw@chromium.org

[commit-bot: I haz the power, 2016-06-29 17:28:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-29 18:21:20]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-29 18:21:26]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-06-29 18:23:21]

Description was changed from

==========
Restrict PPAPI Win32k lockdown to Win10 and above.
This patch restricts enabling Win32k lockdown for PPAPI processes to
Windows 10 and above. It includes a change to the flag text to indicate
it only works on Windows 10.

BUG=523278
==========

to

==========
Restrict PPAPI Win32k lockdown to Win10 and above.
This patch restricts enabling Win32k lockdown for PPAPI processes to
Windows 10 and above. It includes a change to the flag text to indicate
it only works on Windows 10.

BUG=523278

Committed: https://crrev.com/a6fc996adfc9a973536804fb1dcd28c24da84a80
Cr-Commit-Position: refs/heads/master@{#402872}
==========

[commit-bot: I haz the power, 2016-06-29 18:23:22]

Patchset 1 (id:??) landed as
https://crrev.com/a6fc996adfc9a973536804fb1dcd28c24da84a80
Cr-Commit-Position: refs/heads/master@{#402872}

[chrcoluk_msn.com, 2016-11-01 05:31:14]

why has this been restricted to windows 10 when it will work on windows 8.1?


On Wednesday, 29 June 2016 16:28:37 UTC+1, for...@chromium.org wrote:
>
> Reviewers: jam
> CL: https://codereview.chromium.org/2103153003/
>
> Message:
> jam@ could you take at these minor changes I would like to get in before 
> the M53
> branch?
>
> Thanks.
>
> Description:
> Restrict PPAPI Win32k lockdown to Win10 and above.
> This patch restricts enabling Win32k lockdown for PPAPI processes to
> Windows 10 and above. It includes a change to the flag text to indicate
> it only works on Windows 10.
>
> BUG=523278
>
> Base URL: https://chromium.googlesource.com/chromium/src.git@master
>
> Affected files (+4, -1 lines):
> M chrome/app/generated_resources.grd
> M chrome/browser/chrome_content_browser_client.cc
>
>
> Index: chrome/app/generated_resources.grd
> diff --git a/chrome/app/generated_resources.grd 
> b/chrome/app/generated_resources.grd
> index 
>
2b6fc75d50115cacd1a81f777cca1425922ec0fd..9fa7b455e5cf7bf0c71cbd9f501414b607da685b

> 100644
> --- a/chrome/app/generated_resources.grd
> +++ b/chrome/app/generated_resources.grd
> @@ -6736,7 +6736,7 @@ Keep your key file in a safe place. You will need it 
> to create new versions of y
> Enable PPAPI Win32k Lockdown.
> </message>
> <message name="IDS_FLAGS_PPAPI_WIN32K_LOCKDOWN_DESCRIPTION" 
> desc="Description of the flag to enable PPAPI win32k lockdown experiment.">
> - Specify the PPAPI plugins which will be run within the Win32k lockdown 
> sandbox policy.
> + Specify the PPAPI plugins which will be run within the Win32k lockdown 
> sandbox policy (Windows 10 and above only).
> </message>
> <message name="IDS_FLAGS_PPAPI_WIN32K_LOCKDOWN_FLASH_ONLY" desc="Enable 
> Win32k lockdown for Flash">
> Flash only
> Index: chrome/browser/chrome_content_browser_client.cc
> diff --git a/chrome/browser/chrome_content_browser_client.cc 
> b/chrome/browser/chrome_content_browser_client.cc
> index 
>
734bd648622910c5b38e8b5d32d85f8c8f7da74b..dc4ff8dbd8d25186158892b338d1ab4449be0fca

> 100644
> --- a/chrome/browser/chrome_content_browser_client.cc
> +++ b/chrome/browser/chrome_content_browser_client.cc
> @@ -2695,6 +2695,9 @@ bool ChromeContentBrowserClient::PreSpawnRenderer(
>
> bool ChromeContentBrowserClient::IsWin32kLockdownEnabledForMimeType(
> const std::string& mime_type) const {
> + // We don't support PPAPI win32k lockdown prior to Windows 10.
> + if (base::win::GetVersion() < base::win::VERSION_WIN10)
> + return false;
> // First, check if any variation parameters have enabled or disabled this
> // mime type either specifically or globally.
> std::map<std::string, std::string> mime_params;
>
>
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.