Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Issue 2103143003: Add certificate transparency enforcement to SSL client code. (Closed)

Created:
4 years, 5 months ago by Kevin M
Modified:
4 years, 5 months ago
Reviewers:
Khushal
CC:
chromium-reviews, cbentzel+watch_chromium.org, anandc+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, jessicag+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, lethalantidote+watch-blimp_chromium.org, dtrainor+watch-blimp_chromium.org, shaktisahu+watch-blimp_chromium.org, khushalsagar+watch-blimp_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add certificate transparency enforcement to SSL client code. Recently-added policy rules in the SSL client socket require that we enable Certificate Transparency. This CL adds CT support by attaching the relevant CT objects to the SSL client context. R=khushalsagar@chromium.org BUG=623684 Committed: https://crrev.com/fb80da0b554258cbbd22b77e1d159ad17411d4c1 Cr-Commit-Position: refs/heads/master@{#402603}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M blimp/net/ssl_client_transport.h View 2 chunks +4 lines, -0 lines 0 comments Download
M blimp/net/ssl_client_transport.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Kevin M
4 years, 5 months ago (2016-06-28 19:50:59 UTC) #1
Khushal
On 2016/06/28 19:50:59, Kevin M wrote: lgtm. Any idea why the blimp code wasn't updated ...
4 years, 5 months ago (2016-06-28 20:54:28 UTC) #2
maniscalco
Thanks for fixing this! Any idea why our ssl_client_transport_unittest.cc didn't catch it when the policy ...
4 years, 5 months ago (2016-06-28 20:54:29 UTC) #3
Kevin M
This wasn't caught because we use a fake cert verifier for our unit tests. Integration ...
4 years, 5 months ago (2016-06-28 22:20:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2103143003/1
4 years, 5 months ago (2016-06-28 22:21:46 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-28 23:54:53 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-06-28 23:57:52 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fb80da0b554258cbbd22b77e1d159ad17411d4c1
Cr-Commit-Position: refs/heads/master@{#402603}

Powered by Google App Engine
This is Rietveld 408576698