ABANDONED: ash: Support changing default wallpaper at runtime.

ash: Support changing default wallpaper at runtime.

Make DesktopBackgroundController permit the default
wallpaper images to be changed at runtime.

BUG=348136

[Alexander Alekseev, 2014-03-24 23:04:12]

https://codereview.chromium.org/210313004/diff/1/ash/desktop_background/deskt...
File ash/desktop_background/desktop_background_controller.cc (right):

https://codereview.chromium.org/210313004/diff/1/ash/desktop_background/deskt...
ash/desktop_background/desktop_background_controller.cc:230:
GetDefaultWallpaperInfo(is_guest, &old_path, &old_layout, NULL, NULL);
This call returns "Future wallpaper parameters, that would be applied if a call
to SetDefaultWallpaper() is done".
First of all, it depends on "flacky" GetAppropriateResolution() (because another
monitor could be attached and electrical connector could be unstable).

https://codereview.chromium.org/210313004/diff/1/ash/desktop_background/deskt...
ash/desktop_background/desktop_background_controller.cc:233:
large_default_wallpaper_path_ = large_path;
if (is_guest) {
...
} else {
...
}

?

[Daniel Erat, 2014-03-24 23:12:05]

https://codereview.chromium.org/210313004/diff/1/ash/desktop_background/deskt...
File ash/desktop_background/desktop_background_controller.cc (right):

https://codereview.chromium.org/210313004/diff/1/ash/desktop_background/deskt...
ash/desktop_background/desktop_background_controller.cc:230:
GetDefaultWallpaperInfo(is_guest, &old_path, &old_layout, NULL, NULL);
On 2014/03/24 23:04:12, alemate wrote:
> This call returns "Future wallpaper parameters, that would be applied if a
call
> to SetDefaultWallpaper() is done".
> First of all, it depends on "flacky" GetAppropriateResolution() (because
another
> monitor could be attached and electrical connector could be unstable).
> 

"first of all" -> is this the only concern?

is your concern that there could be a previously-scheduled call to
DesktopBackgroundController::UpdateWallpaper() still pending? we could cache the
current small/large status and use that in GetDefaultWallpaperInfo() instead of
re-checking the display size there.

https://codereview.chromium.org/210313004/diff/1/ash/desktop_background/deskt...
ash/desktop_background/desktop_background_controller.cc:233:
large_default_wallpaper_path_ = large_path;
On 2014/03/24 23:04:12, alemate wrote:
> if (is_guest) {
> ...
> } else {
> ...
> }
> 
> ?

do you need to override the default guest wallpaper? we don't allow it to be
customized by OEMs currently, so i was planning to make this method just be used
to change the non-guest default wallpaper.

[Alexander Alekseev, 2014-03-25 00:20:28]

On 2014/03/24 23:12:05, Daniel Erat wrote:
>
https://codereview.chromium.org/210313004/diff/1/ash/desktop_background/deskt...
> File ash/desktop_background/desktop_background_controller.cc (right):
> 
>
https://codereview.chromium.org/210313004/diff/1/ash/desktop_background/deskt...
> ash/desktop_background/desktop_background_controller.cc:230:
> GetDefaultWallpaperInfo(is_guest, &old_path, &old_layout, NULL, NULL);
> On 2014/03/24 23:04:12, alemate wrote:
> > This call returns "Future wallpaper parameters, that would be applied if a
> call
> > to SetDefaultWallpaper() is done".
> > First of all, it depends on "flacky" GetAppropriateResolution() (because
> another
> > monitor could be attached and electrical connector could be unstable).
> > 
> 
> "first of all" -> is this the only concern?
> 
> is your concern that there could be a previously-scheduled call to
> DesktopBackgroundController::UpdateWallpaper() still pending?

Yes.

>  we could cache the
> current small/large status and use that in GetDefaultWallpaperInfo() instead
of
> re-checking the display size there.
This would be more correct.
 
>
https://codereview.chromium.org/210313004/diff/1/ash/desktop_background/deskt...
> ash/desktop_background/desktop_background_controller.cc:233:
> large_default_wallpaper_path_ = large_path;
> On 2014/03/24 23:04:12, alemate wrote:
> > if (is_guest) {
> > ...
> > } else {
> > ...
> > }
> > 
> > ?
> 
> do you need to override the default guest wallpaper? we don't allow it to be
> customized by OEMs currently, so i was planning to make this method just be
used
> to change the non-guest default wallpaper.

I think there could be only output parameter "is_guest", because the caller has
no information of the currently active wallpaper (and pending request).
But you've specified it as input, so I decided that you meant to make universal
method to allow modification of any default wallpaper for some reason.