Remove overloads for Callback in bind_helpers.h

Remove overloads for Callback in bind_helpers.h

The removed overload and specializations are no longer needed, and
they prevent binding move-only functor into a callback.

BUG=554299
Committed: https://crrev.com/14f813fa11da84bd87e240869ae0d1322a41ea9c
Cr-Commit-Position: refs/heads/master@{#402752}

[tzik, 2016-06-28 14:19:56]

Description was changed from

==========
Remove function overloads for Callback in bind_helpers.h

This is a preparation to support binding move-only functor into Callback.

BUG=
==========

to

==========
Remove function overloads for Callback in bind_helpers.h

The removed overload and specializations are no longer needed, and
they prevent binding move-only functor into a callback.

BUG=
==========

[tzik, 2016-06-28 14:19:56]

tzik@chromium.org changed reviewers:
+ yutak@chromium.org

[tzik, 2016-06-28 14:21:12]

Description was changed from

==========
Remove function overloads for Callback in bind_helpers.h

The removed overload and specializations are no longer needed, and
they prevent binding move-only functor into a callback.

BUG=
==========

to

==========
Remove overloads for Callback in bind_helpers.h

The removed overload and specializations are no longer needed, and
they prevent binding move-only functor into a callback.

BUG=554299
==========

[tzik, 2016-06-28 14:33:11]

PTAL

[Yuta Kitamura, 2016-06-29 00:07:55]

LGTM, just have one minor question.

https://codereview.chromium.org/2103113002/diff/1/base/bind_helpers.h
File base/bind_helpers.h (right):

https://codereview.chromium.org/2103113002/diff/1/base/bind_helpers.h#newcode347
base/bind_helpers.h:347: explicit IgnoreResultHelper(T functor) :
functor_(std::move(functor)) {}
Do you expect |T| to be something like Callback<T>? Is
there any other thing?

https://codereview.chromium.org/2103113002/diff/1/base/bind_helpers.h#newcode417
base/bind_helpers.h:417: T&& Unwrap(T&& o) {
aside: If the argument can be an rvalue reference, WTF's
PassedWrapper's mutable can be removed by using rref?

[tzik, 2016-06-29 02:49:08]

https://codereview.chromium.org/2103113002/diff/1/base/bind_helpers.h
File base/bind_helpers.h (right):

https://codereview.chromium.org/2103113002/diff/1/base/bind_helpers.h#newcode347
base/bind_helpers.h:347: explicit IgnoreResultHelper(T functor) :
functor_(std::move(functor)) {}
On 2016/06/29 00:07:55, Yuta Kitamura wrote:
> Do you expect |T| to be something like Callback<T>? Is
> there any other thing?

T is a Functor. That can be Callback<>, function pointers, method pointers, or
IgnoreResult<>.

https://codereview.chromium.org/2103113002/diff/1/base/bind_helpers.h#newcode417
base/bind_helpers.h:417: T&& Unwrap(T&& o) {
On 2016/06/29 00:07:55, Yuta Kitamura wrote:
> aside: If the argument can be an rvalue reference, WTF's
> PassedWrapper's mutable can be removed by using rref?

No. The constness of the internal storage is from Invoker::Run(), which uses
const StorageType.

[tzik, 2016-06-29 04:32:02]

The CQ bit was checked by tzik@chromium.org

[commit-bot: I haz the power, 2016-06-29 04:32:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-29 08:18:53]

Description was changed from

==========
Remove overloads for Callback in bind_helpers.h

The removed overload and specializations are no longer needed, and
they prevent binding move-only functor into a callback.

BUG=554299
==========

to

==========
Remove overloads for Callback in bind_helpers.h

The removed overload and specializations are no longer needed, and
they prevent binding move-only functor into a callback.

BUG=554299
==========

[commit-bot: I haz the power, 2016-06-29 08:18:54]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-29 08:20:26]

Description was changed from

==========
Remove overloads for Callback in bind_helpers.h

The removed overload and specializations are no longer needed, and
they prevent binding move-only functor into a callback.

BUG=554299
==========

to

==========
Remove overloads for Callback in bind_helpers.h

The removed overload and specializations are no longer needed, and
they prevent binding move-only functor into a callback.

BUG=554299

Committed: https://crrev.com/14f813fa11da84bd87e240869ae0d1322a41ea9c
Cr-Commit-Position: refs/heads/master@{#402752}
==========

[commit-bot: I haz the power, 2016-06-29 08:20:27]

Patchset 1 (id:??) landed as
https://crrev.com/14f813fa11da84bd87e240869ae0d1322a41ea9c
Cr-Commit-Position: refs/heads/master@{#402752}