Move zygote related files to components/nacl.

Move zygote related files to components/nacl.

nacl_fork_delegate_linux is running in the zygote process so it is moved to components/nacl/zygote.

This is part of an effort to componentize NaCl code.

BUG=244791
NOTRY=true
R=jam@chromium.org, mseaborn@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=214362

[yael.aharon1, 2013-07-29 16:33:47]

nacl_fork_delegate_linux.cc is running in the zygote process so it is moved to
components/nacl/zygote.
nacl_fork_delegate_linux.h is used outside of components/nacl so it is moved to
components/nacl/common.

Mark. can you please review? thanks!

[yael.aharon1, 2013-07-29 22:09:06]

nacl_fork_delegate_linux.cc is running in the zygote process so it is moved to
components/nacl/zygote.
nacl_fork_delegate_linux.h is used outside of components/nacl so it is moved to
components/nacl/common.

Mark. can you please review? thanks!

[Mark Seaborn, 2013-07-29 22:35:21]

On 29 July 2013 15:09, <yael.aharon@chromium.org> wrote:

> nacl_fork_delegate_linux.cc is running in the zygote process so it is
> moved to
> components/nacl/zygote.
> nacl_fork_delegate_linux.h is used outside of components/nacl so it is
> moved to
> components/nacl/common.
>

It looks odd that the .h file and .cc files are in different directories.

The interface in nacl_fork_delegate_linux.h is only used from code that
runs in Chromium's zygote process, so I think it makes sense to put this
header in components/nacl/zygote/.

I don't think there is a rule that code outside components/ can #include
from components/nacl/common/ but not from the rest of components/nacl/, is
there?  I don't think components/nacl/common/ is special in this respect.
If we wanted to distinguish between parts of components/nacl/ that are
public (#includable from outside) and private, "public" might be a better
subdir name (following the convention set by content/public/) -- but I'm
not sure we need to draw this distinction yet.

Cheers,
Mark

[yael.aharon1, 2013-07-29 22:46:11]

On 2013/07/29 22:35:21, Mark Seaborn wrote:
> On 29 July 2013 15:09, <mailto:yael.aharon@chromium.org> wrote:
> 
> > nacl_fork_delegate_linux.cc is running in the zygote process so it is
> > moved to
> > components/nacl/zygote.
> > nacl_fork_delegate_linux.h is used outside of components/nacl so it is
> > moved to
> > components/nacl/common.
> >
> 
> It looks odd that the .h file and .cc files are in different directories.
> 
> The interface in nacl_fork_delegate_linux.h is only used from code that
> runs in Chromium's zygote process, so I think it makes sense to put this
> header in components/nacl/zygote/.
> 
> I don't think there is a rule that code outside components/ can #include
> from components/nacl/common/ but not from the rest of components/nacl/, is
> there?  I don't think components/nacl/common/ is special in this respect.
> If we wanted to distinguish between parts of components/nacl/ that are
> public (#includable from outside) and private, "public" might be a better
> subdir name (following the convention set by content/public/) -- but I'm
> not sure we need to draw this distinction yet.
> 
> Cheers,
> Mark

I thought there was a rule, but I guess I was wrong.
Moved nacl_fork_delegate_linux.h to components/nacl/zygote.

[Mark Seaborn, 2013-07-29 23:46:40]

LGTM, thanks

[yael.aharon1, 2013-07-30 00:24:40]

jam@ can you please review the changes to the files in chrome/app? thanks!

[jam, 2013-07-30 00:36:14]

lgtm

[commit-bot: I haz the power, 2013-07-30 08:47:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yael.aharon@intel.com/21031004/11001

[yael.aharon, 2013-07-30 15:46:40]

Committed patchset #2 manually as r214362 (presubmit successful).

[commit-bot: I haz the power, 2013-07-30 18:07:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yael.aharon@intel.com/21031004/11001

[commit-bot: I haz the power, 2013-07-30 18:07:11]

Failed to apply patch for components/nacl/zygote/nacl_fork_delegate_linux.cc:
File exist but was about to be overwriten
Patch:   NR 
chrome/app/nacl_fork_delegate_linux.cc->components/nacl/zygote/nacl_fork_delegate_linux.cc
Index: components/nacl/zygote/nacl_fork_delegate_linux.cc
diff --git a/chrome/app/nacl_fork_delegate_linux.cc
b/components/nacl/zygote/nacl_fork_delegate_linux.cc
similarity index 98%
rename from chrome/app/nacl_fork_delegate_linux.cc
rename to components/nacl/zygote/nacl_fork_delegate_linux.cc
index
eef943676e1d39cf3261edf8ae09a22e455f9059..c9efe318859d507e5bfb4b265a2fa0408fcadacb
100644
--- a/chrome/app/nacl_fork_delegate_linux.cc
+++ b/components/nacl/zygote/nacl_fork_delegate_linux.cc
@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#include "chrome/app/nacl_fork_delegate_linux.h"
+#include "components/nacl/zygote/nacl_fork_delegate_linux.h"
 
 #include <signal.h>
 #include <stdlib.h>
@@ -21,7 +21,6 @@
 #include "base/posix/unix_domain_socket_linux.h"
 #include "base/process/launch.h"
 #include "base/third_party/dynamic_annotations/dynamic_annotations.h"
-#include "chrome/common/chrome_paths.h"
 #include "components/nacl/common/nacl_helper_linux.h"
 #include "components/nacl/common/nacl_paths.h"
 #include "components/nacl/common/nacl_switches.h"