Issue 21031003: Fix building icu for android on mac host.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 21031003: Fix building icu for android on mac host. (Closed)

Created:
7 years, 4 months ago by Torne

Modified:
7 years, 4 months ago

Reviewers:
jochen (gone - plz use gerrit)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/deps/third_party/icu46/

Visibility:
Public.

Fix building icu for android on mac host. ICU was not building correctly when OS==android, _toolset=host and host_os=mac. Fix the conditionals to use the right data files when building for host. R=jochen@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=214189

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -9 lines)			Patch
	M	icu.gyp	View	1	2 chunks	+13 lines, -9 lines	0 comments	Download

Total messages: 5 (0 generated)

Torne

Oops, okay, this definitely doesn't work as written :) Let me do some more tests.

7 years, 4 months ago (2013-07-29 12:26:11 UTC) #2

Torne

7 years, 4 months ago (2013-07-29 12:55:51 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r214189 (presubmit successful).