Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Issue 2103093003: Fix '[wasm] Separate compilation from instantiation' (Closed)

Created:
4 years, 5 months ago by ivica.bogosavljevic
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix '[wasm] Separate compilation from instantiation'. Port c1d01aea117c62759cc2be1805493ed59218558c Fix a few failures which occur because instruction cache hasn't been flushed after update of WASM references. BUG=mjsunit/wasm/asm-wasm-heap,mjsunit/wasm/start-function Committed: https://crrev.com/5c86692a5ea00a98898e421580dff63cc530e570 Cr-Commit-Position: refs/heads/master@{#37364}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/assembler.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
ivica.bogosavljevic
One line fix PTAL
4 years, 5 months ago (2016-06-28 12:04:33 UTC) #4
Mircea Trofin
On 2016/06/28 12:04:33, ivica.bogosavljevic wrote: > One line fix > > PTAL Lgtm, thanks!
4 years, 5 months ago (2016-06-28 14:55:57 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2103093003/1
4 years, 5 months ago (2016-06-29 07:05:59 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-06-29 07:33:16 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2103093003/1
4 years, 5 months ago (2016-06-29 07:33:54 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-29 07:36:57 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 07:39:29 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5c86692a5ea00a98898e421580dff63cc530e570
Cr-Commit-Position: refs/heads/master@{#37364}

Powered by Google App Engine
This is Rietveld 408576698