Issue 2103083002: Add protected header for ConfirmInfobarController

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2103083002: Add protected header for ConfirmInfobarController (Closed)

Created:
4 years, 5 months ago by Jackie Quinn

Modified:
4 years, 5 months ago

Reviewers:
jif

CC:
chromium-reviews, sdefresne+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@infobar_picker

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Add protected header for ConfirmInfobarController Moves private methods of ConfirmInfoBarController to protected header so that they may be overridden in subclasses of ConfirmInfoBarController, such as upcoming UpdatePasswordInfoBarController. Also does code modernization pass on ConfirmInfoBarController, i.e. moving underscore to prefix for ivar, using NS_ENUM, declaring ivar in interface category. BUG=622244

Patch Set 1 #

Patch Set 2 : Modernize and update #

Patch Set 3 : Fixup #

Patch Set 4 : Rebase #

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -29 lines)			Patch
M	ios/chrome/browser/BUILD.gn	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	ios/chrome/browser/infobars/confirm_infobar_controller.h	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	ios/chrome/browser/infobars/confirm_infobar_controller.mm	View	1 2	6 chunks	+27 lines, -28 lines	0 comments	Download
A	ios/chrome/browser/infobars/confirm_infobar_controller+protected.h	View	1 2	1 chunk	+19 lines, -0 lines	0 comments	Download
M	ios/chrome/ios_chrome.gyp	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages