Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 2103063002: ServiceWorker: Reland of bypassing SW when no fetch handler existed (Closed)

Created:
4 years, 5 months ago by shimazu
Modified:
4 years, 5 months ago
Reviewers:
horo
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org, kinuko+watch, blink-worker-reviews_chromium.org, falken
Base URL:
https://chromium.googlesource.com/chromium/src.git@return_response_to_forward_to_network
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ServiceWorker: Reland of bypassing SW when no fetch handler existed When the script doesn't have fetch handler, in-scope network requests don't need to go to the service worker. This patch is to bypass it. This patch is a CL for re-landing which was reverted at http://crrev.com/2080793003. This CL should be landed after http://crrev.com/2108573002 is committed. BUG=605844, 621788 TEST=./out/Debug/content_unittests --gtest_filter="ServiceWorkerControlleeRequestHandlerTest.FallbackWithNoFetchHandler*" Committed: https://crrev.com/cb53dfa21239d8be2ed3bc53c83d8c001603cee6 Cr-Commit-Position: refs/heads/master@{#404348}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Use FallbackToNetworkOrRenderer and add a test case #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -6 lines) Patch
M content/browser/service_worker/service_worker_controllee_request_handler.cc View 1 4 chunks +26 lines, -4 lines 0 comments Download
M content/browser/service_worker/service_worker_controllee_request_handler_unittest.cc View 1 7 chunks +56 lines, -2 lines 0 comments Download
M content/browser/service_worker/service_worker_version.h View 1 1 chunk +2 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (6 generated)
shimazu
PTAL at this CL, too.
4 years, 5 months ago (2016-06-28 08:38:24 UTC) #4
horo
https://codereview.chromium.org/2103063002/diff/1/content/browser/service_worker/service_worker_controllee_request_handler.cc File content/browser/service_worker/service_worker_controllee_request_handler.cc (right): https://codereview.chromium.org/2103063002/diff/1/content/browser/service_worker/service_worker_controllee_request_handler.cc#newcode41 content/browser/service_worker/service_worker_controllee_request_handler.cc:41: job->FallbackToNetwork(); I think this should be FallbackToNetworkOrRenderer(). https://codereview.chromium.org/2108573002/diff/1/content/browser/service_worker/service_worker_url_request_job.cc#newcode251
4 years, 5 months ago (2016-06-29 05:38:30 UTC) #5
shimazu
Fixed. PTAL again. https://codereview.chromium.org/2103063002/diff/1/content/browser/service_worker/service_worker_controllee_request_handler.cc File content/browser/service_worker/service_worker_controllee_request_handler.cc (right): https://codereview.chromium.org/2103063002/diff/1/content/browser/service_worker/service_worker_controllee_request_handler.cc#newcode41 content/browser/service_worker/service_worker_controllee_request_handler.cc:41: job->FallbackToNetwork(); On 2016/06/29 05:38:30, horo wrote: ...
4 years, 5 months ago (2016-07-04 07:50:27 UTC) #6
horo
lgtm
4 years, 5 months ago (2016-07-05 03:00:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2103063002/20001
4 years, 5 months ago (2016-07-08 04:17:53 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-08 14:04:28 UTC) #11
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-08 14:05:04 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-08 14:06:28 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cb53dfa21239d8be2ed3bc53c83d8c001603cee6
Cr-Commit-Position: refs/heads/master@{#404348}

Powered by Google App Engine
This is Rietveld 408576698