mash: Convert virtual keyboard system tray item to wm common types

mash: Convert virtual keyboard system tray item to wm common types

This moves another dependency of StatusAreaWidget.

* Move KeyboardUI ownership from Shell to WmShell
* Move files to //ash/common

BUG=619636
TEST=ash_unittests

Committed: https://crrev.com/c3fbf095844d63c6e08a099f9f574d6dbd51f323
Cr-Commit-Position: refs/heads/master@{#402741}

[James Cook, 2016-06-28 22:57:53]

jamescook@chromium.org changed reviewers:
+ msw@chromium.org

[James Cook, 2016-06-28 22:57:53]

msw, please take a look

[msw, 2016-06-29 01:13:47]

lgtm with a nit

https://codereview.chromium.org/2103053004/diff/20001/ash/common/wm_shell.cc
File ash/common/wm_shell.cc (right):

https://codereview.chromium.org/2103053004/diff/20001/ash/common/wm_shell.cc#...
ash/common/wm_shell.cc:8: #include "ash/common/keyboard/keyboard_ui.h"
nit: not needed (forward decl in header should suffice?)

[James Cook, 2016-06-29 05:22:16]

https://codereview.chromium.org/2103053004/diff/20001/ash/common/wm_shell.cc
File ash/common/wm_shell.cc (right):

https://codereview.chromium.org/2103053004/diff/20001/ash/common/wm_shell.cc#...
ash/common/wm_shell.cc:8: #include "ash/common/keyboard/keyboard_ui.h"
On 2016/06/29 01:13:47, msw wrote:
> nit: not needed (forward decl in header should suffice?)

It's needed to run the std::unique_ptr<KeyboardUI> destructor as part of
~WmShell().

[James Cook, 2016-06-29 05:24:17]

(Specifically, I think "delete" needs to know the size of the object it is
deleting. I forget including headers for this reason all the time -- at least
clang has better error messages for this sort of thing than gcc. :-)

[James Cook, 2016-06-29 05:38:30]

Er, wait, it's more complex than that.  Just for my own pedantic-ness....

It's true that there's a static_assert in unique_ptr<> that checks that it knows
the sizeof() the object it is deleting. This ensures it is a complete type.
Deleting an incomplete type is undefined behavior for a bunch of reasons
outlined here:
http://stackoverflow.com/questions/2517245/why-really-deleting-an-incomplete-...

Basically, you need knowledge of the destructor when you delete. So it isn't
really about the size. Whoops.

Annnnnnyway, I should get some sleep. Thanks for the review!

[James Cook, 2016-06-29 05:38:36]

The CQ bit was checked by jamescook@chromium.org

[James Cook, 2016-06-29 05:38:36]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org
Link to the patchset: https://codereview.chromium.org/2103053004/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2016-06-29 05:39:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-29 06:49:01]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-29 06:51:11]

Description was changed from

==========
mash: Convert virtual keyboard system tray item to wm common types

This moves another dependency of StatusAreaWidget.

* Move KeyboardUI ownership from Shell to WmShell
* Move files to //ash/common

BUG=619636
TEST=ash_unittests
==========

to

==========
mash: Convert virtual keyboard system tray item to wm common types

This moves another dependency of StatusAreaWidget.

* Move KeyboardUI ownership from Shell to WmShell
* Move files to //ash/common

BUG=619636
TEST=ash_unittests

Committed: https://crrev.com/c3fbf095844d63c6e08a099f9f574d6dbd51f323
Cr-Commit-Position: refs/heads/master@{#402741}
==========

[commit-bot: I haz the power, 2016-06-29 06:51:12]

Patchset 3 (id:??) landed as
https://crrev.com/c3fbf095844d63c6e08a099f9f574d6dbd51f323
Cr-Commit-Position: refs/heads/master@{#402741}