Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Side by Side Diff: third_party/WebKit/Source/core/editing/EditingStyle.h

Issue 2103043004: Fix EditingStyle::mergeStyle()'s handling of custom properties (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: gtest instead of layout test Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * Copyright (C) 2013 Apple Inc. All rights reserved. 3 * Copyright (C) 2013 Apple Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 16 matching lines...) Expand all
27 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 27 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
28 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 28 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
29 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 29 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
30 */ 30 */
31 31
32 #ifndef EditingStyle_h 32 #ifndef EditingStyle_h
33 #define EditingStyle_h 33 #define EditingStyle_h
34 34
35 #include "core/CSSPropertyNames.h" 35 #include "core/CSSPropertyNames.h"
36 #include "core/CSSValueKeywords.h" 36 #include "core/CSSValueKeywords.h"
37 #include "core/CoreExport.h"
37 #include "core/editing/Position.h" 38 #include "core/editing/Position.h"
38 #include "core/editing/VisibleSelection.h" 39 #include "core/editing/VisibleSelection.h"
39 #include "core/editing/WritingDirection.h" 40 #include "core/editing/WritingDirection.h"
40 #include "platform/heap/Handle.h" 41 #include "platform/heap/Handle.h"
41 #include "wtf/Forward.h" 42 #include "wtf/Forward.h"
42 #include "wtf/TriState.h" 43 #include "wtf/TriState.h"
43 #include "wtf/Vector.h" 44 #include "wtf/Vector.h"
44 #include "wtf/text/WTFString.h" 45 #include "wtf/text/WTFString.h"
45 46
46 namespace blink { 47 namespace blink {
47 48
48 class CSSStyleDeclaration; 49 class CSSStyleDeclaration;
49 class CSSComputedStyleDeclaration; 50 class CSSComputedStyleDeclaration;
50 class ContainerNode; 51 class ContainerNode;
51 class Document; 52 class Document;
52 class Element; 53 class Element;
53 class HTMLElement; 54 class HTMLElement;
54 class MutableStylePropertySet; 55 class MutableStylePropertySet;
55 class Node; 56 class Node;
56 class QualifiedName; 57 class QualifiedName;
57 class ComputedStyle; 58 class ComputedStyle;
58 class StylePropertySet; 59 class StylePropertySet;
59 60
60 class EditingStyle final : public GarbageCollected<EditingStyle> { 61 class CORE_EXPORT EditingStyle final : public GarbageCollected<EditingStyle> {
61 public: 62 public:
62 63
63 enum PropertiesToInclude { AllProperties, OnlyEditingInheritableProperties, EditingPropertiesInEffect }; 64 enum PropertiesToInclude { AllProperties, OnlyEditingInheritableProperties, EditingPropertiesInEffect };
64 enum ShouldPreserveWritingDirection { PreserveWritingDirection, DoNotPreserv eWritingDirection }; 65 enum ShouldPreserveWritingDirection { PreserveWritingDirection, DoNotPreserv eWritingDirection };
65 enum ShouldExtractMatchingStyle { ExtractMatchingStyle, DoNotExtractMatching Style }; 66 enum ShouldExtractMatchingStyle { ExtractMatchingStyle, DoNotExtractMatching Style };
66 static float NoFontDelta; 67 static float NoFontDelta;
67 68
68 static EditingStyle* create() 69 static EditingStyle* create()
69 { 70 {
70 return new EditingStyle(); 71 return new EditingStyle();
(...skipping 159 matching lines...) Expand 10 before | Expand all | Expand 10 after
230 String m_applyFontSize; 231 String m_applyFontSize;
231 }; 232 };
232 233
233 // FIXME: Remove these functions or make them non-global to discourage using CSS StyleDeclaration directly. 234 // FIXME: Remove these functions or make them non-global to discourage using CSS StyleDeclaration directly.
234 CSSValueID getIdentifierValue(CSSStyleDeclaration*, CSSPropertyID); 235 CSSValueID getIdentifierValue(CSSStyleDeclaration*, CSSPropertyID);
235 CSSValueID getIdentifierValue(StylePropertySet*, CSSPropertyID); 236 CSSValueID getIdentifierValue(StylePropertySet*, CSSPropertyID);
236 237
237 } // namespace blink 238 } // namespace blink
238 239
239 #endif // EditingStyle_h 240 #endif // EditingStyle_h
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/css/StylePropertySet.cpp ('k') | third_party/WebKit/Source/core/editing/EditingStyle.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698