Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Unified Diff: chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc

Issue 21030006: NetworkState cleanup, pass properties to InitialPropertiesReceived (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/chromeos/about_network.cc ('k') | chromeos/network/favorite_state.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc
diff --git a/chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc b/chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc
index 7c69089687ffd45cbd71e42633fb62b47c2f99bc..61b801f931bbbb8d377a7ff846af5e026b209736 100644
--- a/chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc
+++ b/chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc
@@ -459,7 +459,7 @@ NetworkInfoDictionary::NetworkInfoDictionary(const FavoriteState* favorite,
connectable_(false),
connection_type_(favorite->type()),
remembered_(true),
- shared_(favorite->IsShared()),
+ shared_(!favorite->IsPrivate()),
policy_managed_(favorite->IsManaged()) {
if (favorite->type() == flimflam::kTypeEthernet)
name_ = l10n_util::GetStringUTF8(IDS_STATUSBAR_NETWORK_DEVICE_ETHERNET);
@@ -1562,7 +1562,7 @@ void PopulateConnectionDetails(const NetworkState* network,
ash::network_connect::ErrorString(network->error()));
dictionary->SetBoolean(kTagRemembered, !network->profile_path().empty());
- bool shared = network->IsShared();
+ bool shared = !network->IsPrivate();
dictionary->SetBoolean(kTagShared, shared);
const std::string& type = network->type();
@@ -1633,7 +1633,7 @@ void PopulateCellularDetails(const NetworkState* cellular,
CommandLine::ForCurrentProcess()->HasSwitch(
chromeos::switches::kEnableCarrierSwitching));
// Cellular network / connection settings.
- dictionary->SetString(kTagNetworkTechnology, cellular->technology());
+ dictionary->SetString(kTagNetworkTechnology, cellular->network_technology());
dictionary->SetString(kTagActivationState,
ActivationStateString(cellular->activation_state()));
dictionary->SetString(kTagRoamingState,
@@ -1785,9 +1785,10 @@ void PopulateCellularDetails(const NetworkState* cellular,
// because the network's proper portal url cannot be generated without it
const NetworkState* default_network =
NetworkHandler::Get()->network_state_handler()->DefaultNetwork();
+ const std::string& technology = cellular->network_technology();
bool force_show_view_account_button =
- (cellular->technology() == flimflam::kNetworkTechnologyLte ||
- cellular->technology() == flimflam::kNetworkTechnologyLteAdvanced) &&
+ (technology == flimflam::kNetworkTechnologyLte ||
+ technology == flimflam::kNetworkTechnologyLteAdvanced) &&
default_network &&
!mdn.empty();
« no previous file with comments | « chrome/browser/ui/webui/chromeos/about_network.cc ('k') | chromeos/network/favorite_state.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698