NetworkState cleanup, pass properties to InitialPropertiesReceived

chromeos/network/managed_state.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROMEOS_NETWORK_MANAGED_STATE_H_
 #define CHROMEOS_NETWORK_MANAGED_STATE_H_
 
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
 #include "chromeos/chromeos_export.h"
 
 namespace base {
 class Value;
+class DictionaryValue;
 }
 
 namespace chromeos {
 
 class DeviceState;
 class FavoriteState;
 class NetworkState;
 
 // Base class for states managed by NetworkStateManger which are associated
 // with a Shill path (e.g. service path or device path).
@@ skipping 23 matching lines @@
   // then the state wasn't modified. This might happen because of
   // * |key| was not recognized.
   // * |value| was not parsed successfully.
   // * |value| is equal to the cached property value.
   // If the return value is true, the state might or might not be modified.
   virtual bool PropertyChanged(const std::string& key,
                                const base::Value& value) = 0;
 
   // Called by NetworkStateHandler after all calls to PropertyChanged for the
   // initial set of properties. Used to update state requiring multiple
   // parsed properties, e.g. name from hex_ssid in NetworkState.

[pneubeck (no reviews), 2013/07/29 19:13:25]

nit: remove 'parsed'

[stevenjb, 2013/07/29 20:25:47]

Done.

-  virtual void InitialPropertiesReceived();
+  // |properties| contains the complete set of initial properties.
+  virtual void InitialPropertiesReceived(
+      const base::DictionaryValue& properties);
 
   const ManagedType managed_type() const { return managed_type_; }
   const std::string& path() const { return path_; }
   const std::string& name() const { return name_; }
   const std::string& type() const { return type_; }
   bool update_requested() const { return update_requested_; }
   void set_update_requested(bool update_requested) {
     update_requested_ = update_requested;
   }
 
@@ skipping 35 matching lines @@
 
   // Tracks when an update has been requested.
   bool update_requested_;
 
   DISALLOW_COPY_AND_ASSIGN(ManagedState);
 };
 
 }  // namespace chromeos
 
 #endif  // CHROMEOS_NETWORK_MANAGED_STATE_H_