Editor: Deffer event dispatch after selection change.

Problem: JS 'focus' handler fired by drag-n-drop can't restore input value.

Solution: enqueue event dispatching, so handlers execute when state is stable.

BUG=263743
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158811

[tkent, 2013-08-25 22:03:58]

+yosin

[yosin_UTC9, 2013-08-26 01:51:12]

Summary of this CL doesn't mean what this patch changes. Please change something
like: Deffer event dispatch after selection change.

Note: content modification is already done before, appliedEdigng().

[yosin_UTC9, 2013-08-26 01:58:54]

https://codereview.chromium.org/21030005/diff/1/LayoutTests/editing/selection...
File LayoutTests/editing/selection/drag-drop-restore.html (right):

https://codereview.chromium.org/21030005/diff/1/LayoutTests/editing/selection...
LayoutTests/editing/selection/drag-drop-restore.html:25:
dst.addEventListener("focus", restoreValue, false);
Please check order of events and action, e.g. selection changed, content edit
event, focus event. This test is too high-level what this patch changed.

[yosin_UTC9, 2013-08-26 05:03:45]

Is it better to dispatch events as IE?

When drag-and-drop from "src" input element to "dst" input element, events are
fired as follows:

CR fires events in following order:
 - drop dst
 - blur src
 - focus dst
 - input src
 - input dst

IE fires events in following order:
 - drop dst
 - input dst
 - blur src
 - focus dst
 - input src

FireFox fires events in following order:
 - drop dst
 - input dst
("focus" event isn't fired)

# I think browsers should fire "change" event to "src".

[yosin_UTC9, 2013-08-26 05:14:16]

You can see list of events for drag-and-drop by http://jsfiddle.net/6r4zV/

[eseidel, 2013-09-03 18:59:09]

It would be nice to add Yohsifumi's test.  This change looks reasonable to me,
but I'm not sure I fully understand the compatibility consequences.

[eustas, 2013-09-19 13:15:59]

Added order event test.

PTAL

[eseidel, 2013-09-19 15:05:47]

lgtm.  Ideally we'd get yosin's lgtm too.

[yosin_UTC9, 2013-09-20 03:53:57]

https://codereview.chromium.org/21030005/diff/13001/LayoutTests/editing/selec...
File LayoutTests/editing/selection/drag-drop-events.html (right):

https://codereview.chromium.org/21030005/diff/13001/LayoutTests/editing/selec...
LayoutTests/editing/selection/drag-drop-events.html:22: var span =
document.createElement("span");
nit: Using debug() can reduce code and use id="console" instead id="log".

https://codereview.chromium.org/21030005/diff/13001/LayoutTests/editing/selec...
LayoutTests/editing/selection/drag-drop-events.html:28: var events = ['blur',
'change', 'drop', 'focus', 'input'];
nit: You can do

['blur', 'change', 'drop', 'focus', 'input'].forEach(function(event) {
    src.addEventListener(event, log.bind(null, event + ' src'));
    dst.addEventListener(event, log.bind(null, event + ' dst'));
});

[eustas, 2013-09-20 05:13:15]

https://codereview.chromium.org/21030005/diff/13001/LayoutTests/editing/selec...
File LayoutTests/editing/selection/drag-drop-events.html (right):

https://codereview.chromium.org/21030005/diff/13001/LayoutTests/editing/selec...
LayoutTests/editing/selection/drag-drop-events.html:22: var span =
document.createElement("span");
On 2013/09/20 03:53:58, Yoshifumi Inoue wrote:
> nit: Using debug() can reduce code and use id="console" instead id="log".

Done.

https://codereview.chromium.org/21030005/diff/13001/LayoutTests/editing/selec...
LayoutTests/editing/selection/drag-drop-events.html:28: var events = ['blur',
'change', 'drop', 'focus', 'input'];
On 2013/09/20 03:53:58, Yoshifumi Inoue wrote:
> nit: You can do
> 
> ['blur', 'change', 'drop', 'focus', 'input'].forEach(function(event) {
>     src.addEventListener(event, log.bind(null, event + ' src'));
>     dst.addEventListener(event, log.bind(null, event + ' dst'));
> });

Done.

[yosin_UTC9, 2013-09-20 05:14:54]

ACK
Thanks!

[eseidel, 2013-09-20 18:20:15]

lgtm

[commit-bot: I haz the power, 2013-09-20 18:21:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/eustas@chromium.org/21030005/23001

[commit-bot: I haz the power, 2013-09-20 22:01:28]

Retried try job too often on mac_blink_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_blink_...

[commit-bot: I haz the power, 2013-10-03 13:53:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/eustas@chromium.org/21030005/43001

[commit-bot: I haz the power, 2013-10-03 13:54:30]

Change committed as 158811