Add support for KeyboardEvent.getModifierState()

Add support for KeyboardEvent.getModifierState()

Add support for KeyboardEvent.getModifierState() as per the latest specification:
http://www.w3.org/TR/DOM-Level-3-Events/#events-KeyboardEvent-getModifierState

Note that only the following modifiers are currently supported (crbug.com/265458):
"Control", "Alt", "Shift", "Meta".

BUG=263724
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155158

[Mike West, 2013-07-29 14:01:06]

Can you upload the patch again? I'm seeing "chunk mismatch", which means
Reitveld went crazy. :(

[do-not-use, 2013-07-29 14:04:06]

On 2013/07/29 14:01:06, Mike West wrote:
> Can you upload the patch again? I'm seeing "chunk mismatch", which means
> Reitveld went crazy. :(

Done. Seems to be working now.

[Mike West, 2013-07-29 14:09:34]

LGTM, thanks for filing the followup bug for the pieces that aren't working yet.

[garykac, 2013-07-29 16:18:00]

lgtm

https://codereview.chromium.org/21030004/diff/11001/Source/core/dom/KeyboardE...
File Source/core/dom/KeyboardEvent.cpp (right):

https://codereview.chromium.org/21030004/diff/11001/Source/core/dom/KeyboardE...
Source/core/dom/KeyboardEvent.cpp:161: // "AltGraph", "CapsLock", "Fn",
"NumLock", "ScrollLock", "SymbolLock", "OS".
Note that we're working to clarify some of these keys in the current DOM3 WD.

For example, the "Fn" key is a hardware key used on keyboards with a limited
amount of physical space. It is not exposed to the key events.

Please let me know if you're planning on doing any work on this soon.

[ojan, 2013-07-29 22:05:35]

lgtm

[commit-bot: I haz the power, 2013-07-30 06:03:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/21030004/11001

[commit-bot: I haz the power, 2013-07-30 10:27:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/21030004/11001

[commit-bot: I haz the power, 2013-07-30 10:50:04]

Change committed as 155158

[arv (Not doing code reviews), 2013-07-31 16:22:54]

https://chromiumcodereview.appspot.com/21030004/diff/11001/LayoutTests/fast/e...
File LayoutTests/fast/events/keyboardevent-getModifierState.html (right):

https://chromiumcodereview.appspot.com/21030004/diff/11001/LayoutTests/fast/e...
LayoutTests/fast/events/keyboardevent-getModifierState.html:14: ev = ev ||
event;
why?

event is not defined (unless you count the deprecated window.event IE-ism)

https://chromiumcodereview.appspot.com/21030004/diff/11001/LayoutTests/fast/e...
LayoutTests/fast/events/keyboardevent-getModifierState.html:15: ev.keyCode =
(ev.which || ev.keyCode);
This looks bad. Why are we assigning keyCode to `which`? Isn't `which` just an
NN4-ism?