Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(667)

Unified Diff: net/websockets/websocket_stream_create_test_base.cc

Issue 2102993002: Fix WebSocket to set first party for cookies (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update testRunner calls to setBlockThirdPartyCookies() Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/websockets/websocket_stream_create_test_base.h ('k') | net/websockets/websocket_stream_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/websockets/websocket_stream_create_test_base.cc
diff --git a/net/websockets/websocket_stream_create_test_base.cc b/net/websockets/websocket_stream_create_test_base.cc
index 0d68b6228e139c6d3de7e676c16dd57670e45e2f..354c5d7e0a67dc3334072e7927d7d123c0fcdb6f 100644
--- a/net/websockets/websocket_stream_create_test_base.cc
+++ b/net/websockets/websocket_stream_create_test_base.cc
@@ -98,9 +98,10 @@ WebSocketStreamCreateTestBase::~WebSocketStreamCreateTestBase() {
}
void WebSocketStreamCreateTestBase::CreateAndConnectStream(
- const std::string& socket_url,
+ const GURL& socket_url,
const std::vector<std::string>& sub_protocols,
const url::Origin& origin,
+ const GURL& first_party_for_cookies,
const std::string& additional_headers,
std::unique_ptr<base::Timer> timer) {
for (size_t i = 0; i < ssl_data_.size(); ++i) {
@@ -114,9 +115,9 @@ void WebSocketStreamCreateTestBase::CreateAndConnectStream(
new DeterministicKeyWebSocketHandshakeStreamCreateHelper(delegate,
sub_protocols));
stream_request_ = CreateAndConnectStreamForTesting(
- GURL(socket_url), std::move(create_helper), origin, additional_headers,
- url_request_context_host_.GetURLRequestContext(), BoundNetLog(),
- std::move(connect_delegate),
+ socket_url, std::move(create_helper), origin, first_party_for_cookies,
+ additional_headers, url_request_context_host_.GetURLRequestContext(),
+ BoundNetLog(), std::move(connect_delegate),
timer ? std::move(timer)
: std::unique_ptr<base::Timer>(new base::Timer(false, false)));
}
« no previous file with comments | « net/websockets/websocket_stream_create_test_base.h ('k') | net/websockets/websocket_stream_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698