Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Unified Diff: third_party/WebKit/Source/core/dom/Document.cpp

Issue 2102993002: Fix WebSocket to set first party for cookies (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: a Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/Document.cpp
diff --git a/third_party/WebKit/Source/core/dom/Document.cpp b/third_party/WebKit/Source/core/dom/Document.cpp
index 0237c178a90d10d43bb4150ec865e83db8984ccb..310d0912ef7e718f06233481e1b571cfbc070a1d 100644
--- a/third_party/WebKit/Source/core/dom/Document.cpp
+++ b/third_party/WebKit/Source/core/dom/Document.cpp
@@ -4167,6 +4167,10 @@ const KURL Document::firstPartyForCookies() const
if (importsController() && importsController()->master() && importsController()->master() != this)
return importsController()->master()->firstPartyForCookies();
+ if (!frame()) {
+ return SecurityOrigin::urlWithUniqueSecurityOrigin();
+ }
Mike West 2016/07/05 08:45:10 Nit: No {} for single line bodies. Would you mind
tyoshino (SeeGerritForStatus) 2016/07/05 14:41:27 Fixed
+
// TODO(mkwst): This doesn't correctly handle sandboxed documents; we want to look at their URL,
// but we can't because we don't know what it is.
Frame* top = frame()->tree().top();

Powered by Google App Engine
This is Rietveld 408576698