third_party/WebKit/LayoutTests/http/tests/websocket/cookie-ws-to-ws.html - Issue 2102993002: Fix WebSocket to set first party for cookies

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/websocket/cookie-ws-to-ws.html

Issue 2102993002: Fix WebSocket to set first party for cookies (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: a Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/security/cookies/websocket/third-party-cookie-blocked-on-same-origin-websocket.html ('k') | third_party/WebKit/LayoutTests/http/tests/websocket/cookie-ws-to-ws-expected.txt » ('j') | third_party/WebKit/Source/core/dom/Document.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/websocket/cookie-ws-to-ws.html

diff --git a/third_party/WebKit/LayoutTests/http/tests/websocket/cookie-ws-to-ws.html b/third_party/WebKit/LayoutTests/http/tests/websocket/cookie-ws-to-ws.html

index 2e00682e06157c7e059f84567df32aaf61979a1f..4581873d1ce5b26497782eae6660d6a6d11d54e9 100644

--- a/third_party/WebKit/LayoutTests/http/tests/websocket/cookie-ws-to-ws.html

+++ b/third_party/WebKit/LayoutTests/http/tests/websocket/cookie-ws-to-ws.html

@@ -22,7 +22,7 @@ ws_set_cookie.onopen = function () {

ws_set_cookie.onclose = function (e) {

connectAndGetRequestHeader('cookie').then(function(value) {

cookie = normalizeCookie(value);

- shouldBeEqualToString('cookie', 'WK-WebSocket-test-domain-pass=1; WK-WebSocket-test-path-pass=1; WK-WebSocket-test=1');

+ shouldBeEqualToString('cookie', 'WK-WebSocket-test-domain-pass=1; WK-WebSocket-test-path-pass=1; WK-WebSocket-test=1; same-site-lax=1; same-site-strict=1');

clear();

}, finishAsFailed);

};