third_party/WebKit/LayoutTests/http/tests/security/cookies/websocket/resources/third-party-iframe.html - Issue 2102993002: Fix WebSocket to set first party for cookies

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/security/cookies/websocket/resources/third-party-iframe.html

Issue 2102993002: Fix WebSocket to set first party for cookies (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: a Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../../../../websocket/resources/get-request-header.js"></script>

	3 <script src="../../../../websocket/resources/cookie-test-util.js"></script>
	Mike West 2016/06/28 11:25:37 Nit: Ditto with the `..` bits. Nit: Ditto with the `..` bits. tyoshino (SeeGerritForStatus) 2016/06/30 08:24:13 Done. Show quoted text On 2016/06/28 11:25:37, Mike West (OOO through 4th) wrote: > Nit: Ditto with the `..` bits. Done.
	4 <script>

	5 function notifySuccess(value) {

	6 window.parent.postMessage('DONE', '*');

	7 }

	8

	9 function notifyFailure(reason) {

	10 window.parent.postMessage('FAIL: ' + reason, '*');

	11 }

	12

	13 setCookie(CROSS_ORIGIN_WS_SERVER).then(

	14 () => connectAndGetRequestHeadersFrom(CROSS_ORIGIN_WS_SERVER),

	15 notifyFailure

	16 ).then(

	17 headers => {

	18 const cookie = headers['cookie'];

	19 return clear(CROSS_ORIGIN_WS_SERVER).then(() => {

	20 if (cookie === undefined) {

	21 notifySuccess();

	22 } else {

	23 notifyFailure('cookie was not undefined: ' + cookie);

	24 }

	25 });

	26 }

	27 ).catch(

	28 notifyFailure

	29 );

	30 </script>

OLD	NEW