third_party/WebKit/LayoutTests/http/tests/security/cookies/websocket/first-party-cookie-accepted.html - Issue 2102993002: Fix WebSocket to set first party for cookies

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/security/cookies/websocket/first-party-cookie-accepted.html

Issue 2102993002: Fix WebSocket to set first party for cookies (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added TODO for mkwst Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « net/websockets/websocket_stream_test.cc ('k') | third_party/WebKit/LayoutTests/http/tests/security/cookies/websocket/resources/set-cookie.html » ('j') | third_party/WebKit/public/platform/modules/websockets/WebSocketHandle.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="/resources/testharness.js"></script>

	3 <script src="/resources/testharnessreport.js"></script>

	4 <script src="/websocket/resources/get-request-header.js"></script>

	5 <script src="/websocket/resources/cookie-test-util.js"></script>

	6 <script>

	7 if (window.testRunner) {

	8 // Block third-party cookies.

	9 testRunner.setAlwaysAcceptCookies(false);

	10 }

	11

	12 const origin = WS_ORIGIN;

	13

	14 async_test(t => {
	yhirano 2016/07/06 11:19:08 [optional] I prefer promise_test to async_test if [optional] I prefer promise_test to async_test if test is composed of several promise operations. tyoshino (SeeGerritForStatus) 2016/07/07 07:00:44 Changed Show quoted text On 2016/07/06 11:19:08, yhirano wrote: > [optional] I prefer promise_test to async_test if test is composed of several > promise operations. Changed
	15 setCookie(origin).then(

	16 t.step_func(() => {

	17 return connectAndGetRequestHeadersFrom(origin);

	18 }),

	19 t.unreached_func('Failed to set cookie.')

	20 ).then(

	21 t.step_func(headers => {

	22 const cookie = headers['cookie'];

	23 assert_not_equals(cookie, undefined,

	24 'headers should contain a cookie header.');

	25 assert_equals(

	26 normalizeCookie(cookie),

	27 'WK-WebSocket-test-domain-pass=1; WK-WebSocket-test-path-pass=1; ' +

	28 'WK-WebSocket-test=1; same-site-lax=1; same-site-strict=1');

	29 return clear(origin);

	30 }),

	31 t.unreached_func('Cookie header lookup failed.')

	32 ).then(

	33 t.done.bind(t),

	34 t.unreached_func('Failed to clear cookies.')

	35 );

	36 }, "Test that first-party cookies not blocked for WebSockets.");

	37 </script>

OLD	NEW