Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Side by Side Diff: content/browser/renderer_host/offscreen_canvas_surface_impl.cc

Issue 2102973005: Fix Crash on destructor of OffscreenCanvasSurfaceImpl during ConnectionError (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/renderer_host/offscreen_canvas_surface_impl.h" 5 #include "content/browser/renderer_host/offscreen_canvas_surface_impl.h"
6 6
7 #include "base/bind_helpers.h" 7 #include "base/bind_helpers.h"
8 #include "cc/surfaces/surface.h" 8 #include "cc/surfaces/surface.h"
9 #include "cc/surfaces/surface_manager.h" 9 #include "cc/surfaces/surface_manager.h"
10 #include "content/browser/compositor/surface_utils.h" 10 #include "content/browser/compositor/surface_utils.h"
(...skipping 10 matching lines...) Expand all
21 21
22 OffscreenCanvasSurfaceImpl::OffscreenCanvasSurfaceImpl( 22 OffscreenCanvasSurfaceImpl::OffscreenCanvasSurfaceImpl(
23 mojo::InterfaceRequest<blink::mojom::OffscreenCanvasSurface> request) 23 mojo::InterfaceRequest<blink::mojom::OffscreenCanvasSurface> request)
24 : id_allocator_(CreateSurfaceIdAllocator()), 24 : id_allocator_(CreateSurfaceIdAllocator()),
25 binding_(this, std::move(request)) {} 25 binding_(this, std::move(request)) {}
26 26
27 OffscreenCanvasSurfaceImpl::~OffscreenCanvasSurfaceImpl() { 27 OffscreenCanvasSurfaceImpl::~OffscreenCanvasSurfaceImpl() {
28 if (!GetSurfaceManager()) { 28 if (!GetSurfaceManager()) {
29 // Inform both members that SurfaceManager's no longer alive to 29 // Inform both members that SurfaceManager's no longer alive to
30 // avoid their destruction errors. 30 // avoid their destruction errors.
31 surface_factory_->didDestroySurfaceManager(); 31 if (surface_factory_)
32 id_allocator_->didDestroySurfaceManager(); 32 surface_factory_->didDestroySurfaceManager();
33 if (id_allocator_)
34 id_allocator_->didDestroySurfaceManager();
33 } 35 }
34 surface_factory_->Destroy(surface_id_); 36 surface_factory_->Destroy(surface_id_);
35 } 37 }
36 38
37 void OffscreenCanvasSurfaceImpl::GetSurfaceId( 39 void OffscreenCanvasSurfaceImpl::GetSurfaceId(
38 const GetSurfaceIdCallback& callback) { 40 const GetSurfaceIdCallback& callback) {
39 DCHECK_CURRENTLY_ON(BrowserThread::UI); 41 DCHECK_CURRENTLY_ON(BrowserThread::UI);
40 42
41 surface_id_ = id_allocator_->GenerateId(); 43 surface_id_ = id_allocator_->GenerateId();
42 44
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
76 const cc::ReturnedResourceArray& resources) {} 78 const cc::ReturnedResourceArray& resources) {}
77 79
78 void OffscreenCanvasSurfaceImpl::WillDrawSurface(cc::SurfaceId id, 80 void OffscreenCanvasSurfaceImpl::WillDrawSurface(cc::SurfaceId id,
79 const gfx::Rect& damage_rect) { 81 const gfx::Rect& damage_rect) {
80 } 82 }
81 83
82 void OffscreenCanvasSurfaceImpl::SetBeginFrameSource( 84 void OffscreenCanvasSurfaceImpl::SetBeginFrameSource(
83 cc::BeginFrameSource* begin_frame_source) {} 85 cc::BeginFrameSource* begin_frame_source) {}
84 86
85 } // namespace content 87 } // namespace content
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698