Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 2102973004: Do not load alternative service from disk for non-https servers. (Closed)

Created:
4 years, 5 months ago by Bence
Modified:
4 years, 5 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not load alternative service from disk for non-https servers. Such records might exists from earlier installations that used to allow alternative services for other schemes. Includes regression test. BUG=615497 Committed: https://crrev.com/b5b35f012b6d2e5c943cee9fad51e23a98ba1303 Cr-Commit-Position: refs/heads/master@{#403084}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -27 lines) Patch
M net/http/http_server_properties_manager.h View 1 chunk +2 lines, -0 lines 0 comments Download
M net/http/http_server_properties_manager.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M net/http/http_server_properties_manager_unittest.cc View 12 chunks +45 lines, -27 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Bence
Raman: PTAL. I am not familiar with the different HttpServerPropertiesVersions, so I'm not sure if ...
4 years, 5 months ago (2016-06-29 17:35:55 UTC) #2
ramant (doing other things)
Hi Bence, Changes LGTM.
4 years, 5 months ago (2016-06-29 18:00:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2102973004/1
4 years, 5 months ago (2016-06-30 03:30:40 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-30 03:49:33 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 03:51:45 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b5b35f012b6d2e5c943cee9fad51e23a98ba1303
Cr-Commit-Position: refs/heads/master@{#403084}

Powered by Google App Engine
This is Rietveld 408576698