Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1309)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_from_try_jobs.py

Issue 2102963003: Print a warning and continue if no results could be fetched in rebaseline_from_try_jobs.py. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: - Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_from_try_jobs.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_from_try_jobs.py b/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_from_try_jobs.py
index 051ef3fda1ef711a650b17a2cbe2808b8e0349c6..6d8f1118769e18fa330e43957f6a67cc2fb5d4fe 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_from_try_jobs.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_from_try_jobs.py
@@ -46,6 +46,9 @@ class RebaselineFromTryJobs(AbstractParallelRebaselineCommand):
results_url = self._results_url(try_job.builder_name, try_job.master_name, try_job.build_number)
builder = self._tool.buildbot.builder_with_name(try_job.builder_name, try_job.master_name)
layout_test_results = builder.fetch_layout_test_results(results_url)
+ if layout_test_results is None:
wkorman 2016/06/29 18:30:17 Is this preferred to: if not layout_test_results:
+ _log.warning('Failed to request layout test results from "%s".', results_url)
+ return []
return layout_test_results.unexpected_mismatch_results()
def execute(self, options, args, tool):
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698