Issue 2102943002: Unimport two iframe tests.

Issue 2102943002: Unimport two iframe tests. (Closed)

Created:
4 years, 5 months ago by tkent

Modified:
4 years, 5 months ago

Reviewers:
Rick Byers

CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews, darin-cc_chromium.org, jam, tfarina, qyearsley

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Unimport two iframe tests. * cross_origin_parentage.html needs an HTTP server. * same_origin_parentage.html needs an extra HTML resource. TBR=rbyers@chromium.org NOTRY=true Committed: https://crrev.com/3636550e4bac4cadaee1a4c756264e5e6b3907e0 Cr-Commit-Position: refs/heads/master@{#402361}

Patch Set 1 #

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2 lines, -50 lines)			Patch
M	third_party/WebKit/LayoutTests/W3CImportExpectations	View	2 chunks	+2 lines, -0 lines	0 comments	Download
D	third_party/WebKit/LayoutTests/imported/wpt/html/semantics/embedded-content/the-iframe-element/cross_origin_parentage.html	View	1 chunk	+0 lines, -19 lines	0 comments	Download
D	third_party/WebKit/LayoutTests/imported/wpt/html/semantics/embedded-content/the-iframe-element/cross_origin_parentage-expected.txt	View	1 chunk	+0 lines, -6 lines	0 comments	Download
D	third_party/WebKit/LayoutTests/imported/wpt/html/semantics/embedded-content/the-iframe-element/same_origin_parentage.html	View	1 chunk	+0 lines, -19 lines	0 comments	Download
D	third_party/WebKit/LayoutTests/imported/wpt/html/semantics/embedded-content/the-iframe-element/same_origin_parentage-expected.txt	View	1 chunk	+0 lines, -6 lines	0 comments	Download

Messages

Total messages: 8 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2102943002/1

4 years, 5 months ago (2016-06-28 01:22:39 UTC) #3

commit-bot: I haz the power

Patchset 1 (id:??) landed as https://crrev.com/3636550e4bac4cadaee1a4c756264e5e6b3907e0 Cr-Commit-Position: refs/heads/master@{#402361}

4 years, 5 months ago (2016-06-28 01:29:27 UTC) #6

Rick Byers

LGTM Sorry I missed these. Were they failing on the bots? I'd like to understand ...

4 years, 5 months ago (2016-06-28 15:09:41 UTC) #7

tkent

4 years, 5 months ago (2016-06-28 23:00:33 UTC) #8

Message was sent while issue was closed.

On 2016/06/28 at 15:09:41, rbyers wrote:
> Sorry I missed these.  Were they failing on the bots?  I'd like to understand
how I missed them / why the CQ didn't catch them.

No problems.  They didn't fail on bots, and I found them by manual triage.
I prefer not importing tests we can't run correctly at this moment.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages