Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Issue 2102933002: Version 5.2.361.25 (cherry-pick) (Closed)

Created:
4 years, 5 months ago by adamk
Modified:
4 years, 5 months ago
Reviewers:
Dan Ehrenberg
CC:
PaweĊ‚ Hajdan Jr., ulan, v8-merges_googlegroups.com, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@5.2
Target Ref:
refs/pending/branch-heads/5.2
Project:
v8
Visibility:
Public.

Description

Version 5.2.361.25 (cherry-pick) Merged 0e14baf712955a1993f742647bb2adc293702b80 Rewrite scopes of non-simple default arguments BUG=chromium:616386 LOG=N R=littledan@chromium.org Committed: https://chromium.googlesource.com/v8/v8/+/559143978207787f4976404d66c30e8a70fb9580

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -2 lines) Patch
M include/v8-version.h View 1 chunk +1 line, -1 line 0 comments Download
M src/parsing/parameter-initializer-rewriter.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/parsing/parser.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/parsing/pattern-rewriter.cc View 1 chunk +21 lines, -1 line 0 comments Download
A test/mjsunit/regress/regress-616386.js View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
adamk
4 years, 5 months ago (2016-06-28 01:04:52 UTC) #1
Dan Ehrenberg
lgtm
4 years, 5 months ago (2016-06-28 01:07:10 UTC) #2
adamk
4 years, 5 months ago (2016-06-28 01:14:25 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
559143978207787f4976404d66c30e8a70fb9580.

Powered by Google App Engine
This is Rietveld 408576698