Issue 210293005: Resource: Add more crash preventing assertions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 210293005: Resource: Add more crash preventing assertions (Closed)

Created:
6 years, 9 months ago by Hajime Morrita

Modified:
6 years, 9 months ago

Reviewers:
Nate Chapin, kouhei (in TOK), eseidel

CC:
blink-reviews, Nate Chapin, gavinp+loader_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

Resource: Add more crash preventing assertions This is another attempt to investigate crashes in the wild. This change deploys more RELEASE_ASSERT() to see if/where the wrongly-killed Resource objects appear. BUG=352043 TEST=none R=eseidel, japhet@chromium.org, kouhei Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169905

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -6 lines)			Patch
	M	Source/core/fetch/Resource.h	View		3 chunks	+10 lines, -1 line	0 comments	Download
	M	Source/core/fetch/Resource.cpp	View		7 chunks	+18 lines, -5 lines	0 comments	Download

Total messages: 5 (0 generated)

Hajime Morrita

PTAL? Honestly I have totally no idea what's happening on the crash. What I can ...

6 years, 9 months ago (2014-03-25 00:59:45 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/morrita@chromium.org/210293005/1

6 years, 9 months ago (2014-03-25 02:37:07 UTC) #4

Message was sent while issue was closed.

Change committed as 169905