Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2985)

Unified Diff: base/memory/shared_memory_unittest.cc

Issue 2102923002: Change MessagePumpForGpu and SharedMemory to ScopedHandle (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed unit tests Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/memory/shared_memory_unittest.cc
diff --git a/base/memory/shared_memory_unittest.cc b/base/memory/shared_memory_unittest.cc
index 8251f6084021c737ba01fb3986513d52da254d23..f29865c21aee054cc1368968263d8b317d53ea10 100644
--- a/base/memory/shared_memory_unittest.cc
+++ b/base/memory/shared_memory_unittest.cc
@@ -592,11 +592,6 @@ TEST(SharedMemoryTest, UnsafeImageSection) {
EXPECT_FALSE(shared_memory_open.Map(1));
EXPECT_EQ(nullptr, shared_memory_open.memory());
- SharedMemory shared_memory_handle_dup(
stanisc 2016/06/29 18:36:18 This part of the test is redundant (identical to t
- SharedMemoryHandle(section_handle.Get(), ::GetCurrentProcessId()), true);
- EXPECT_FALSE(shared_memory_handle_dup.Map(1));
- EXPECT_EQ(nullptr, shared_memory_handle_dup.memory());
-
SharedMemory shared_memory_handle_local(
SharedMemoryHandle(section_handle.Take(), ::GetCurrentProcessId()), true);
EXPECT_FALSE(shared_memory_handle_local.Map(1));

Powered by Google App Engine
This is Rietveld 408576698