Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2102903005: Make the mojo::WaitMany() wrapper insist on std::vectors. (Closed)

Created:
4 years, 5 months ago by viettrungluu
Modified:
4 years, 5 months ago
Reviewers:
vardhan
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Make the mojo::WaitMany() wrapper insist on std::vectors. This simplifies a bunch of stuff. R=vardhan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/e7f7109538aa329d05c83ec2983df71fc32e52aa

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -47 lines) Patch
M mojo/public/cpp/system/wait.h View 3 chunks +17 lines, -47 lines 1 comment Download

Messages

Total messages: 7 (1 generated)
viettrungluu
4 years, 5 months ago (2016-06-28 19:37:17 UTC) #1
viettrungluu
4 years, 5 months ago (2016-06-29 15:58:11 UTC) #2
viettrungluu
(I meant to say ping.)
4 years, 5 months ago (2016-06-29 16:48:01 UTC) #3
vardhan
lgtm https://codereview.chromium.org/2102903005/diff/1/mojo/public/cpp/system/wait.h File mojo/public/cpp/system/wait.h (right): https://codereview.chromium.org/2102903005/diff/1/mojo/public/cpp/system/wait.h#newcode59 mojo/public/cpp/system/wait.h:59: const std::vector<HandleType>& handles, I'm guessing it used to ...
4 years, 5 months ago (2016-06-29 18:02:18 UTC) #4
viettrungluu
On 2016/06/29 18:02:18, vardhan wrote: > lgtm > > https://codereview.chromium.org/2102903005/diff/1/mojo/public/cpp/system/wait.h > File mojo/public/cpp/system/wait.h (right): > ...
4 years, 5 months ago (2016-06-29 18:05:32 UTC) #5
viettrungluu
4 years, 5 months ago (2016-06-29 18:05:56 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
e7f7109538aa329d05c83ec2983df71fc32e52aa (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698