Issue 2102903004: [Cronet] Unregister NetLog observer during shutdown

Issue 2102903004: [Cronet] Unregister NetLog observer during shutdown (Closed)

Created:
4 years, 5 months ago by xunjieli

Modified:
4 years, 5 months ago

Reviewers:
kapishnikov

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

[Cronet] Unregister NetLog observer during shutdown This CL unregisters |write_to_file_observer_| and destroy it when CronetUrlRequestContextAdapter is torn down if there is an observer. R=kapishnikov@chromium.org BUG=623701 Committed: https://crrev.com/62fdf21f191556d3592f7d5cf69820d230792770 Cr-Commit-Position: refs/heads/master@{#402548}

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+43 lines, -5 lines)			Patch
M	components/cronet/android/cronet_url_request_context_adapter.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	components/cronet/android/cronet_url_request_context_adapter.cc	View	3 chunks	+11 lines, -5 lines	0 comments	Download
M	components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java	View	1 chunk	+28 lines, -0 lines	0 comments	Download

Total messages: 8 (3 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2102903004/20001

4 years, 5 months ago (2016-06-28 18:25:03 UTC) #5

commit-bot: I haz the power

4 years, 5 months ago (2016-06-28 21:37:23 UTC) #8

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/62fdf21f191556d3592f7d5cf69820d230792770
Cr-Commit-Position: refs/heads/master@{#402548}