Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2102903003:
Clean up GN args for chromecast (Closed)
|
Created:
4 years, 5 months ago by antz1 Modified:
4 years, 5 months ago Reviewers:
asanka, slan, brettw, Dirk Pranke, wzhong, Randy Smith (Not in Mondays), xunjieli, mattm, pauljensen, scottmg, agl CC:
chromium-reviews, cbentzel+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionClean up GN args for chromecast
BUG=None
Committed: https://crrev.com/1110ea9acc1aa86fa92a2ca0b2871e07a18582a6
Cr-Commit-Position: refs/heads/master@{#404007}
Patch Set 1 #
Messages
Total messages: 30 (13 generated)
Description was changed from ========== Clean up GN args for chromecast BUG=None ========== to ========== Clean up GN args for chromecast BUG=None ==========
antz@chromium.org changed reviewers: + brettw@chromium.org, dpranke@chromium.org, scottmg@chromium.org, slan@chromium.org, wzhong@chromium.org
lgtm
The CQ bit was checked by antz@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
Thanks for the audit! Two questions out of curiosity: 1) What is the goal here? Is it to reduce the binary size of cast_shell? How much savings do we get? 2) Why this particular set of features? There are several features in this file that are equally non-essential on Cast builds as the ones you've excluded. What distinguishes these features from the others?
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
On 2016/06/28 17:42:33, slan wrote: > Thanks for the audit! Two questions out of curiosity: > > 1) What is the goal here? Is it to reduce the binary size of cast_shell? How > much savings do we get? > > 2) Why this particular set of features? There are several features in this file > that are equally non-essential on Cast builds as the ones you've excluded. What > distinguishes these features from the others? There are two goals for this audit: 1. reduce the binary size of cast shell 2. address possible security holes (remove ftp/file support). The total saving is actually not very significant, ~100kb, but we felt disabling ftp support would be good. I ran through the list and tried to identify potential features to be turned off, there are features I would like to turn off but it causes compilation errors (due to implicit dependencies and possibly other issues that I am still investigating). I would sync with you offline on which features are not essential, would be great to get more insights.
antz@chromium.org changed reviewers: + agl@chromium.org, asanka@chromium.org, mattm@chromium.org
lgtm
The CQ bit was checked by antz@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
antz@chromium.org changed reviewers: + pauljensen@chromium.org, rdsmith@chromium.org, xunjieli@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by antz@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by antz@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Clean up GN args for chromecast BUG=None ========== to ========== Clean up GN args for chromecast BUG=None ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
CQ bit was unchecked.
Message was sent while issue was closed.
Description was changed from ========== Clean up GN args for chromecast BUG=None ========== to ========== Clean up GN args for chromecast BUG=None Committed: https://crrev.com/1110ea9acc1aa86fa92a2ca0b2871e07a18582a6 Cr-Commit-Position: refs/heads/master@{#404007} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/1110ea9acc1aa86fa92a2ca0b2871e07a18582a6 Cr-Commit-Position: refs/heads/master@{#404007} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
