appengine/cmd/milo/frontend/templates/buildbot/pages/build.html - Issue 2102903002: Milo: Extract the rietveld information from buildbot.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/cmd/milo/frontend/templates/buildbot/pages/build.html

Issue 2102903002: Milo: Extract the rietveld information from buildbot. (Closed) Base URL: https://chromium.googlesource.com/external/github.com/luci/luci-go@master

Patch Set: comment Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « appengine/cmd/milo/frontend/expectations/buildbot-buildbot.TestableBuild-Debug_page-_win_chromium_rel_ng_246309.html ('k') | appengine/cmd/milo/frontend/testdata/buildbot/win_chromium_rel_ng.246309.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: appengine/cmd/milo/frontend/templates/buildbot/pages/build.html

diff --git a/appengine/cmd/milo/frontend/templates/buildbot/pages/build.html b/appengine/cmd/milo/frontend/templates/buildbot/pages/build.html

index 267fb16a7fdf304f6fe774cc2451be7a87f9a309..02c1566eb723b284a200e0ee13988a2938f9e415 100644

--- a/appengine/cmd/milo/frontend/templates/buildbot/pages/build.html

+++ b/appengine/cmd/milo/frontend/templates/buildbot/pages/build.html

@@ -51,8 +51,8 @@

<tr><td class="left">Got Revision</td><td>{{ .Commit.Revision }}</td></tr>

- {{ if .Commit.ChangelistURL }}

- <tr><td class="left">Patch</td><td><a href="{{.Commit.ChangelistURL}}">YES</a></td></tr>

+ {{ if .Commit.Changelist }}

+ <tr><td class="left">Patch</td><td>{{ .Commit.Changelist | linkify }}</td></tr>

</table>