appengine/cmd/milo/buildbot/structs.go - Issue 2102903002: Milo: Extract the rietveld information from buildbot.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/cmd/milo/buildbot/structs.go

Issue 2102903002: Milo: Extract the rietveld information from buildbot. (Closed) Base URL: https://chromium.googlesource.com/external/github.com/luci/luci-go@master

Patch Set: comment Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « appengine/cmd/milo/buildbot/html_data.go ('k') | appengine/cmd/milo/buildbot/testdata/buildbot/win_chromium_rel_ng.246309.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: appengine/cmd/milo/buildbot/structs.go

diff --git a/appengine/cmd/milo/buildbot/structs.go b/appengine/cmd/milo/buildbot/structs.go

index 6b2a3be7e26bcc0db1bb57eaf52d80a65ec8e7a7..0cf245bc06c5acc613d471fca57f315a1dd5a45e 100644

--- a/appengine/cmd/milo/buildbot/structs.go

+++ b/appengine/cmd/milo/buildbot/structs.go

@@ -62,9 +62,13 @@ type buildbotBuild struct {

// This needs to be reflected. This can be either a String or a buildbotStep.

Currentstep interface{} `json:"currentStep" gae:"-"`

// We don't care about this one.

- Eta interface{} `json:"eta" gae:"-"`

- Logs [][]string `json:"logs" gae:"-"`

- Number int `json:"number"`

+ Eta interface{} `json:"eta" gae:"-"`

+ Logs [][]string `json:"logs" gae:"-"`

+ Number int `json:"number"`

+ // This is a slice of tri-tuples of [property name, value, source].

+ // property name is always a string

+ // value can be a string or float

+ // source is optional, but is always a string if present

Properties [][]interface{} `json:"properties" gae:"-"`

Reason string `json:"reason"`

Results *int `json:"results" gae:"-"`