Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 2102883005: Chrome UI string changes. providing <ex> for <ph> tags. (Closed)

Created:
4 years, 5 months ago by Moe
Modified:
4 years, 5 months ago
Reviewers:
Mathieu
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Chrome UI string changes. providing <ex> for <ph> tags. BUG=624503 Committed: https://crrev.com/ef5b4a2339a11c17bd4632e0606d851f6698476f Cr-Commit-Position: refs/heads/master@{#403167}

Patch Set 1 : Initial #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/app/generated_resources.grd View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
Moe
Mathieu, Please take a look at this. Apparently <ex></ex> tags are now required for all ...
4 years, 5 months ago (2016-06-29 20:34:01 UTC) #2
Mathieu
lgtm
4 years, 5 months ago (2016-06-29 21:18:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2102883005/20001
4 years, 5 months ago (2016-06-30 13:57:21 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 5 months ago (2016-06-30 14:00:43 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 14:02:22 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ef5b4a2339a11c17bd4632e0606d851f6698476f
Cr-Commit-Position: refs/heads/master@{#403167}

Powered by Google App Engine
This is Rietveld 408576698