Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2102883004: Remove redundant variable declaration in pdf/basic_plugin_test.js. (Closed)

Created:
4 years, 5 months ago by jaepark
Modified:
4 years, 5 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove redundant variable declaration in pdf/basic_plugin_test.js. Committed: https://crrev.com/625e2c8105ebb18772ac3cd939d9bbeef48cde56 Cr-Commit-Position: refs/heads/master@{#402695}

Patch Set 1 #

Patch Set 2 : Remove unused variable in pdfium_engine. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M pdf/pdfium/pdfium_engine.cc View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
jaepark
4 years, 5 months ago (2016-06-29 01:30:09 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2102883004/1
4 years, 5 months ago (2016-06-29 01:38:03 UTC) #5
Lei Zhang
lgtm
4 years, 5 months ago (2016-06-29 01:50:18 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-06-29 02:52:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2102883004/1
4 years, 5 months ago (2016-06-29 02:56:38 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-29 03:00:41 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 03:02:47 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/625e2c8105ebb18772ac3cd939d9bbeef48cde56
Cr-Commit-Position: refs/heads/master@{#402695}

Powered by Google App Engine
This is Rietveld 408576698