Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Side by Side Diff: chrome/browser/file_select_helper_mac.mm

Issue 2102883002: Update FileSelectHelper to use RenderFrameHost notifications. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Comment on why test is disabled. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/file_select_helper.cc ('k') | chrome/browser/iframe_browsertest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/file_select_helper.h" 5 #include "chrome/browser/file_select_helper.h"
6 6
7 #include <Cocoa/Cocoa.h> 7 #include <Cocoa/Cocoa.h>
8 #include <sys/stat.h> 8 #include <sys/stat.h>
9 9
10 #include "base/files/file.h" 10 #include "base/files/file.h"
(...skipping 120 matching lines...) Expand 10 before | Expand all | Expand 10 after
131 // Typically, |temporary_files| are deleted after |web_contents_| is 131 // Typically, |temporary_files| are deleted after |web_contents_| is
132 // destroyed. If |web_contents_| is already NULL, then the temporary files 132 // destroyed. If |web_contents_| is already NULL, then the temporary files
133 // need to be deleted now. 133 // need to be deleted now.
134 if (!web_contents_) { 134 if (!web_contents_) {
135 DeleteTemporaryFiles(); 135 DeleteTemporaryFiles();
136 RunFileChooserEnd(); 136 RunFileChooserEnd();
137 return; 137 return;
138 } 138 }
139 } 139 }
140 140
141 NotifyRenderViewHostAndEnd(files); 141 NotifyRenderFrameHostAndEnd(files);
142 } 142 }
OLDNEW
« no previous file with comments | « chrome/browser/file_select_helper.cc ('k') | chrome/browser/iframe_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698