Issue 21028008: add dox to SkTDynamicHash, fix typo of Key instead of KEY

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 21028008: add dox to SkTDynamicHash, fix typo of Key instead of KEY (Closed)

Created:
7 years, 4 months ago by reed1

Modified:
7 years, 4 months ago

Reviewers:
mtklein

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

add dox to SkTDynamicHash, fix typo of Key instead of KEY BUG= R=mtklein@google.com Committed: https://code.google.com/p/skia/source/detail?r=10465

Patch Set 1 #

Total comments: 1

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -8 lines)			Patch
	M	src/core/SkTDynamicHash.h	View		2 chunks	+19 lines, -8 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

mtklein

lgtm https://codereview.chromium.org/21028008/diff/1/src/core/SkTDynamicHash.h File src/core/SkTDynamicHash.h (right): https://codereview.chromium.org/21028008/diff/1/src/core/SkTDynamicHash.h#newcode27 src/core/SkTDynamicHash.h:27: // signal empty/unused. add a ) ?

7 years, 4 months ago (2013-07-29 18:51:22 UTC) #2

reed1

7 years, 4 months ago (2013-07-31 18:02:58 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r10465 (presubmit successful).

Expand Messages | Collapse Messages